Use rustc-demangle to detect wbindgen symbols even under v0 mangling#5006
Closed
fasterthanlime wants to merge 1 commit into
Closed
Use rustc-demangle to detect wbindgen symbols even under v0 mangling#5006fasterthanlime wants to merge 1 commit into
fasterthanlime wants to merge 1 commit into
Conversation
Contributor
Author
|
After looking into this a bit more, it seems that the wasm-bindgen placeholder shows up not only in the Wasm file—which then needs patching after running wasm-bindgen—but also in the generated JavaScript file, which also needs patching. That’s just too many workarounds for me. So for now, I’m going to assume wasm-bindgen is basically broken under v0, and I’ll test it again in a month or so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. #5005