fix(cli): skip uncaptured workspace hotpatch crates#5597
Open
mirsella wants to merge 1 commit into
Open
Conversation
Hotpatch replay can include workspace reverse-dependents that were not part of the app build graph, so their rustc arguments were never captured. Filter replay to captured workspace lib targets and warn when uncaptured reverse-dependents are skipped instead of failing the rebuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Fixes #5540
Workspace hotpatch replay can include reverse-dependents that were not part of the initial app build graph. Those crates have no captured rustc args, so thin replay failed with Missing rustc args for replay.
Validation