Skip to content

fix: Panic in ClientRequest::new when using base_path #5605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NoeTerrier wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix: Panic in ClientRequest::new when using base_path #5605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/fullstack/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,12 @@ impl ClientRequest {
// Shrink monomorphization bloat by moving this to its own function
fn fetch_inner(method: http::Method, path: String, query: String) -> ClientRequest {
// On wasm, this doesn't matter since we always use relative URLs when making requests anyways
let mut server_url = get_server_url();
let mut server_url = get_server_url().to_string();

if server_url.is_empty() {
server_url = "http://this.is.not.a.real.url:9000";
server_url = "http://this.is.not.a.real.url:9000".to_string();
} else if server_url.starts_with("/") {
server_url = format!("http://this.is.not.a.real.url:9000{}", server_url);
}

let url = format!(
Expand Down