fix: ReadStore from MappedMutSignal requires Lens: Readable#5607
Merged
Conversation
Member
Yes, that is right. We map the maximal version, but depending on the bounds it may only implement readable.
That would be great. We currently only have checks set up against the main branch. I tried to change the base branch, but it looks like you may need to rebase your changes |
MonaMayrhofer
force-pushed
the
fix-readstore
branch
from
09733ab to
2f220cb
Compare
Contributor
Author
|
Alrighty :D |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5603
Please note that I am not well versed in the dioxus codebase.
Changing the bound on the
Fromimpl seems to work and compile for my use case, but I do not know if there are any deeper implications of changing that bound.Also the body of the impl contains
value.selector.map_writer- should this still be "map_writer" if the value is readable and not writable?For now i have created the pull-request against v0.7 because that is where i could test in in the context of a bigger codebase, but i can change the base to be main if that is desired.