Copy public directory files verbatim instead of running the asset optimizer#5651
Open
LucaCappelletti94 wants to merge 1 commit into
Open
Copy public directory files verbatim instead of running the asset optimizer#5651LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files in the
public/directory are documented as served as-is, butdx serveanddx bundleboth ran them through the asset optimizer, and the two did not always agree. A.jsentry gets inlined and minified, which shiftsimport.meta.urland can drop the entry's re-exports, so a worker module could work throughdx bundleand fail underdx serve.This bit us building a multi-threaded wasm app with
wasm-bindgen-rayon(no-bundlerfeature). Abuild.rsemits thewasm-bindgen --target webglue plus a smallloader.jsentry intopublic/, and the entry re-exports the glue because the pool spawns blob workers that re-import it by URL and callpkg.default(...)andpkg.wbg_rayon_start_worker(...). Once those exports were optimized away, every pool worker threwTypeError: r.default is not a functionand theSharedArrayBufferpool never came up, while the same code ran fine throughdx bundle. So it was a development-only break.Copying
public/verbatim also stops optimizing public CSS and images, which matches the served-as-is contract (asset!()stays the path for assets you want optimized).