Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: Better Share, Better Error Handling, General Cleanup #447

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

DogeDark
Copy link
Member

@DogeDark DogeDark commented Feb 17, 2025

This PR:

  • Renames ExampleProject struct to Project, introducing the concept of a "Project"
  • The Project struct was moved to model out of example-projects
  • Projects can be shared via server API which calls to GitHub Gists.
  • Server now needs a GIST_AUTH_TOKEN environment variable.
  • A new ApiClient struct which acts as a reqwest client for server <-> playground comms.
  • AppError was moved to model to help unify a standard error type.
  • An Errors struct & context is now provided for components to gracefully push errors which will then be rendered in a modal and logged.
  • We now have a monaco_ready signal. It is not yet used everywhere.
  • A Cors and br compression layer has been added to the server. Cors is set to permissive.
  • Adjusted the template settings for smaller builds (1mb, brotli 400kb instead of 36mb)
  • Adds example & target rebuilding so the examples and server is primed at startup!

Closes #418
Closes #419

@DogeDark DogeDark added enhancement New feature or request playground labels Feb 17, 2025
@DogeDark DogeDark marked this pull request as ready for review February 18, 2025 01:03
@DogeDark DogeDark requested a review from jkelleyrtp February 18, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request playground
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Client-Server Error Handling Save To Gists
1 participant