-
Notifications
You must be signed in to change notification settings - Fork 42
Switch to libcurl + mbedtls #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Updated from Purplecord again. Still need to port Libcurl + Mbedtls to Windows NT 3.1 to be able to call this PR complete. |
|
Since you are porting libcurl + mbedtls, wouldn't it be beneficial to separate that from the frontend and throw that in the backend? A Linux frontend would also benefit from curl. The alternative would be to bring Boost.Beast into the codebase, and good luck porting that to NT 3.1. Although you're already using Boost.Asio and Beast is based on that, so... A good alternative would be to depend on IXWebSocket which supports mbedtls and also provides WebSocket, TLS, HTTP client/server functionality etc. with minimal dependencies, so perhaps you can consider this (Abbadon, discord.cpp, DisCPP and Tokio use it, so it definitely fits for a Discord client). |
Not really. The
No... just duplicate all the CURL stuff for Linux. |
|
Also it's worth mentioning again, but I will not be using the |
|
This is a mess. I think I will close this PR and redo the work in a separate branch. Same with the other stuff |
|
@iProgramMC You happen to take a look at this? https://retrocoding.net/secure-oldies-v-windows-3x-and-winsock-11
Does it just fail to compile for nt 3.1? Or does the handshake fail for some random reason? |
@1jammer1 Probably, I didn't actually try. I am going to start porting mbedtls and libcurl to Windows NT 3.1 at some point, but currently, the porting effort hasn't begun. |
As of now, this works. But the MSVC build only runs on Windows 7 and later and I didn't even get started on the MinGW versions.