Skip to content

ENG-1203: add schema for global left sidebar settings #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sid597 wants to merge 1 commit into
base: eng-1193-feature-flag-left-sidebar
Choose a base branch
from
+17 −2
Open

ENG-1203: add schema for global left sidebar settings #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions apps/roam/src/data/blockPropsSettingsConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
export const DG_BLOCK_PROP_SETTINGS_PAGE_TITLE ="roam/js/discourse-graph/block-prop-settings";
export const TOP_LEVEL_BLOCK_PROP_KEYS = { featureFlags: "Feature Flags" };
export const DG_BLOCK_PROP_SETTINGS_PAGE_TITLE =
"roam/js/discourse-graph/block-prop-settings";
export const TOP_LEVEL_BLOCK_PROP_KEYS = {
featureFlags: "Feature Flags",
global: "Global",
};
11 changes: 11 additions & 0 deletions apps/roam/src/utils/zodSchemaForSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@ import { z } from "zod";
export const FeatureFlagsSchema = z.object({
"Enable Left Sidebar": z.boolean().default(false),
});

export const GlobalSettingsSchema = z.object({
"Left Sidebar": z.object({
Children: z.array(z.string()),
Settings: z.object({
Foldable: z.boolean(),
"Truncate at": z.number().int(),
}),
}),
});
/* eslint-disable @typescript-eslint/naming-convention */

export type FeatureFlags = z.infer<typeof FeatureFlagsSchema>;
export type GlobalSettings = z.infer<typeof GlobalSettingsSchema>;