ENG-754 - migrate shapes to BaseBoxShapeUtil

[mdroidian]

Summary by CodeRabbit

• Refactor
  • Optimized the internal rendering and resizing architecture for improved performance and maintainability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[linear]

ENG-754 We should probably migrate shapes to BaseBoxShapeUtil

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[mdroidian]

@coderabbitai full review

[mdroidian]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

The base class of BaseDiscourseNodeUtil is changed from ShapeUtil<DiscourseNodeShape> to BaseBoxShapeUtil<DiscourseNodeShape>. The custom getGeometry() method and onResize handler are removed, delegating this functionality to the parent class. Related imports are updated accordingly.

Changes

Cohort / File(s)	Summary
Inheritance refactoring apps/roam/src/components/canvas/DiscourseNodeUtil.tsx	Base class changed from ShapeUtil to BaseBoxShapeUtil; custom getGeometry() and onResize methods removed; imports updated to reflect new parent class

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• ENG-995 - Node bounding box doesn't align with borders of the shape in tldraw #667: Modifies how DiscourseNode geometry is obtained; while the main PR removes custom getGeometry implementation, this PR switches indicator sizing to use editor.getShapeGeometry.
• [ENG-599] Discourse node shape #341: Aligns DiscourseNodeUtil to use BaseBoxShapeUtil as the base class, complementing the inheritance structure change in this PR.
• ENG 581 Add ability to change size/font in Discourse Shape #348: Modifies the same BaseDiscourseNodeUtil class; adds size/font properties while this PR removes custom geometry and resize handlers.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically summarizes the main change: migrating shapes to use BaseBoxShapeUtil, which matches the primary refactoring shown in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}