spring support for graphQl schema generator #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create Configuration class for all relavant class - add to stg spring support - add parameter springModuleName - turn protected TypeProvider constructor to public - masked injector code from posts project
fix - masked injector code from posts project
fix 2 - masked injector code from posts project
|
create Configuration class for all relavant class
|
- masked injector code from posts project
brimworks
reviewed
May 10, 2019
| @@ -4,16 +4,19 @@ | |||
| <maven>3.0</maven> | |||
| </prerequisites> | |||
|
|
|||
| <groupId>com.distelli.graphql</groupId> | |||
There was a problem hiding this comment.
Does the groupId get inherited from the parent?
| content); | ||
| } else if (springModuleName != null && stGroup.isDefined("springModule") ) { | ||
| PackageClassName packageClassName = getPackageClassName(springModuleName); | ||
| final String body = " /*\n" + |
There was a problem hiding this comment.
Can't we simply put this in the string template file?
| import graphql.language.TypeName; | ||
| import graphql.language.UnionTypeDefinition; | ||
| import graphql.language.Value; | ||
| import graphql.language.*; |
There was a problem hiding this comment.
Perhaps your editor did this, but I'd prefer to avoid star imports :).
| @@ -295,7 +307,7 @@ public class <model.name>TypeProvider implements Provider\<GraphQLInputObjectTyp | |||
| .type(<it.graphQLType>) | |||
| .name("<it.name>") | |||
| <if(it.defaultValue)> | |||
| .defaultValue(<it.defaultValue>) | |||
| .defaultValue(<if(it.isStringValue)>"<it.defaultValue>"<else><it.defaultValue><endif>) | |||
There was a problem hiding this comment.
We should really fix the STModel so that <it.defaultValue> properly escapes as a string or number... specifically, if the default value is a string with a double quote, it won't generate correct code.
| <if(model.idField)> | ||
| @Bean | ||
| public <model.packageName>.<model.name>.Resolver _<model.name>Resolver(){ | ||
| return list -> list; |
There was a problem hiding this comment.
Maybe Function.identity()?
https://docs.oracle.com/javase/8/docs/api/java/util/function/Function.html#identity--
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create Configuration class for all relavant class