Skip to content

Develop #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
worhs02 merged 2 commits into from
Nov 11, 2025
Merged

Develop #211

worhs02 merged 2 commits into from
Nov 11, 2025

Conversation

@worhs02
Copy link
Collaborator

@worhs02 worhs02 commented Nov 11, 2025

๐Ÿ”— ๊ด€๋ จ ์ด์Šˆ

์—ฐ๊ด€๋œ ์ด์Šˆ ๋ฒˆํ˜ธ๋ฅผ ์ ์–ด์ฃผ์„ธ์š”. (์˜ˆ: #123)
#210

๐Ÿ“Œ PR ์š”์•ฝ

PR์— ๋Œ€ํ•œ ๊ฐ„๋žตํ•œ ์„ค๋ช…์„ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”.
(์˜ˆ: ํ•ด๋‹น ๋ณ€๊ฒฝ ์‚ฌํ•ญ์˜ ๋ชฉ์ ์ด๋‚˜ ์ฃผ์š” ๋‚ด์šฉ)

๐Ÿ“‘ ์ž‘์—… ๋‚ด์šฉ

์ž‘์—…์˜ ์„ธ๋ถ€ ๋‚ด์šฉ์„ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”.

  1. ์ž‘์—… ๋‚ด์šฉ 1
  2. ์ž‘์—… ๋‚ด์šฉ 2
  3. ์ž‘์—… ๋‚ด์šฉ 3

์Šคํฌ๋ฆฐ์ƒท (์„ ํƒ)

๐Ÿ’ก ์ถ”๊ฐ€ ์ฐธ๊ณ  ์‚ฌํ•ญ

PR์— ๋Œ€ํ•ด ์ถ”๊ฐ€์ ์œผ๋กœ ๋…ผ์˜ํ•˜๊ฑฐ๋‚˜ ์ฐธ๊ณ ํ•ด์•ผ ํ•  ๋‚ด์šฉ์„ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”.
(์˜ˆ: ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์ฝ”๋“œ๋ฒ ์ด์Šค์— ๋ฏธ์น˜๋Š” ์˜ํ–ฅ, ํ…Œ์ŠคํŠธ ๋ฐฉ๋ฒ• ๋“ฑ)

worhs02 and others added 2 commits November 11, 2025 12:56
@worhs02
fix/#209: Facade ํŒจํ„ด ์ ์šฉ์œผ๋กœ ์ˆœํ™˜์ฐธ์กฐ ํ•ด๊ฒฐ
74f2f69 
  MemberServiceImpl๊ณผ LogBookService ๊ฐ„ ์ˆœํ™˜์ฐธ์กฐ๋ฅผ ํ•ด๊ฒฐํ•˜๊ธฐ ์œ„ํ•ด
  MyPageFacade๋ฅผ ๋„์ž…ํ•˜์—ฌ ์—ฌ๋Ÿฌ ๋„๋ฉ”์ธ ์„œ๋น„์Šค ์กฐํ•ฉ ์ฑ…์ž„์„ ๋ถ„๋ฆฌ

  ๋ณ€๊ฒฝ์‚ฌํ•ญ:
  - MyPageFacade ์ƒ์„ฑ: Member์™€ LogBook ๋„๋ฉ”์ธ ์กฐํ•ฉ
  - MemberServiceImpl์—์„œ LogBookService ์˜์กด์„ฑ ์ œ๊ฑฐ
  - LogBookService๊ฐ€ MemberService ์ธํ„ฐํŽ˜์ด์Šค ์˜์กด์œผ๋กœ ๋ณ€๊ฒฝ
  - MemberController์—์„œ MyPageFacade ์‚ฌ์šฉ

  ์•„ํ‚คํ…์ฒ˜ ๊ฐœ์„ :
  - ๋„๋ฉ”์ธ ์„œ๋น„์Šค๋Š” ๊ฐ์ž ๋„๋ฉ”์ธ๋งŒ ๋‹ด๋‹น
  - Facade๊ฐ€ ์—ฌ๋Ÿฌ ๋„๋ฉ”์ธ ์กฐํ•ฉ (Use Case ๋ ˆ์ด์–ด)
  - ํ–ฅํ›„ ์†Œ์…œ/์นœ๊ตฌ ๊ธฐ๋Šฅ ํ™•์žฅ์„ฑ ํ™•๋ณด
@worhs02
Merge pull request #210 from DivaryOfficial/fix/#209-Circular-Dependeโ€ฆ
7322b18 
โ€ฆncy-between-member-logbook

 fix/#209: Facade ํŒจํ„ด ์ ์šฉ์œผ๋กœ ์ˆœํ™˜์ฐธ์กฐ ํ•ด๊ฒฐ
@worhs02 worhs02 self-assigned this Nov 11, 2025
@worhs02 worhs02 requested a review from sereene November 11, 2025 08:53
@worhs02 worhs02 merged commit ea43a39 into main Nov 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sereene sereene Awaiting requested review from sereene

Assignees

@worhs02 worhs02

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@worhs02