Skip to content

UI: align edit-page Save/Delete actions with camera button - #866

Open
akira69 wants to merge 4 commits into
Donkie:masterfrom
akira69:feat/ui-floating-edit-actions-upstream-split
Open

UI: align edit-page Save/Delete actions with camera button#866
akira69 wants to merge 4 commits into
Donkie:masterfrom
akira69:feat/ui-floating-edit-actions-upstream-split

Conversation

@akira69

@akira69 akira69 commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keeps the Save / Delete action group floating beside the global camera button on the filament, spool, and manufacturer edit pages.
  • Uses shared positioning so the action group stays overlaid and aligned on both desktop and mobile layouts.
  • Removes the extra floating background bar so only the buttons float beside the camera button.

What Changed

  • Applied the shared floating action styles globally from client/src/index.tsx.
  • Rendered Refine's edit footer buttons into a shared .floating-form-actions container on:
    • filament edit
    • spool edit
    • vendor/manufacturer edit
  • Anchored the QR scanner FloatButton to the same CSS variables used by the floating edit actions.
  • Simplified the floating action container to positioning-only layout with no extra background, border, or shadow behind the buttons.

Visual Impact

  • Before: action buttons at default footer location, separated from camera control flow and not floating
image image
  • After: action buttons float near camera controls for faster edit workflow (web)
image
  • After: on mobile
image

Testing Performed

cd /Users/dfinch/Code/Spoolman_Labels/worktrees/pr866/client && npm ci
cd /Users/dfinch/Code/Spoolman_Labels/worktrees/pr866/client && ./node_modules/.bin/eslint src/components/qrCodeScanner.tsx src/pages/filaments/edit.tsx src/pages/spools/edit.tsx src/pages/vendors/edit.tsx src/index.tsx src/pages/spools/create.tsx src/contexts/color-mode/index.tsx
cd /Users/dfinch/Code/Spoolman_Labels/worktrees/pr866/client && ./node_modules/.bin/prettier --check src/components/qrCodeScanner.tsx src/pages/filaments/edit.tsx src/pages/spools/edit.tsx src/pages/vendors/edit.tsx src/index.tsx src/pages/spools/create.tsx src/contexts/color-mode/index.tsx src/utils/overrides.css
cd /Users/dfinch/Code/Spoolman_Labels/worktrees/pr866/client && VITE_APIURL=/api/v1 npm run build
cd /Users/dfinch/Code/Spoolman_Labels/worktrees/pr866 && PATH=.venv/bin:$PATH SPOOLMAN_DIR_DATA=/tmp/spoolman_pr_866_data uv run uvicorn spoolman.main:app --host 0.0.0.0 --port 9866
curl -sSf http://localhost:9866/api/v1/vendor/1
curl -sSf http://localhost:9866/api/v1/filament/1
curl -sSf http://localhost:9866/api/v1/spool/1

Browser validation on http://localhost:9866 with Playwright:

  • Desktop (1440x900): /vendor/edit/1, /filament/edit/1, and /spool/edit/1 kept the floating Delete / Save group beside the camera button with matching positioning across all three pages.
  • Mobile (390x844): the same three edit pages kept the floating actions in-view and aligned beside the camera button.
  • Style check: the floating action container is transparent with no extra border or shadow, leaving only the buttons visible beside the camera button.
  • Save actions were exercised on vendor, filament, and spool edit pages and confirmed via live API reads.
  • Delete buttons were exercised on disposable vendor, filament, and spool edit pages up to the confirmation popover (Cancel + confirm Delete visible on all three).

Test Checklist

  • npm ci
  • Targeted frontend ESLint for touched TSX files
  • Targeted Prettier check for touched TSX/CSS files
  • Frontend rebuild with VITE_APIURL=/api/v1
  • Backend restart on localhost:9866
  • Playwright desktop validation for vendor, filament, and spool edit pages
  • Playwright mobile validation for vendor, filament, and spool edit pages
  • Save action validation on vendor, filament, and spool edit pages
  • Delete action reachability validation through the confirmation popover on vendor, filament, and spool edit pages

@akira69
akira69 force-pushed the feat/ui-floating-edit-actions-upstream-split branch from 608e7a9 to e45a3c0 Compare February 24, 2026 17:36
@akira69
akira69 force-pushed the feat/ui-floating-edit-actions-upstream-split branch from e45a3c0 to cc708e7 Compare February 24, 2026 17:44
@akira69
akira69 marked this pull request as ready for review February 24, 2026 18:01
@akira69
akira69 marked this pull request as draft February 26, 2026 16:47
@akira69
akira69 marked this pull request as ready for review February 26, 2026 17:12
@akira69 akira69 closed this Mar 2, 2026
@akira69 akira69 reopened this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant