checksums: support all OpenSSL EVP digests #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatuska
force-pushed
the
evpdigests
branch
3 times, most recently
from
26e6a73 to
6862fa4
Compare
|
@liweitianux please take look at this proposed change, now it is well readable |
|
Hi @mmatuska, thank you for the updated patch. It looks good. I'll take care of it a bit later, likely the next week. By the way, I'm wondering why you want it to support digests other than MD5. Are there any real use cases that MD5 is insufficient on your side? Thanks. |
Add option "-c digest" to use any of supported EVP message digests inplace of insecure MD5. This generates checksum files named by the digest by default, e.g .SHA256.CHECKSUMS For backwards compatibility -m translates to -c md5 The "-M filename" option to rename the checksums file remains untouched
|
I have changed the patch to keep all function and file names to make the reading even simpler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option "-c digest" to use any of supported EVP message digests inplace of insecure MD5. This generates checksum files named by the digest by default, e.g .SHA256.CHECKSUMS
For backwards compatibility -m translates to -c md5
The "-M filename" option to rename the checksums file remains untouched