Update to 1.19.4.#129
Open
gniftygnome wants to merge 1 commit into
Open
Conversation
ghost
mentioned this pull request
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires the updated Magna here: Draylar/magna#28
ItemGroupAccessorin favor ofItemGroups.getGroups()I've tested Creative inventory and Survival crafting and block breaking, so I think the major features are intact. In some cases where I'm not certain exactly why something is the way it is I've tried to preserve existing behavior. The following items should probably be reviewed.
I'm not sure about changing
HammerData.groupto be an Identifier. This might affect an API and/or Magna. However, the String name of ItemGroups is only for display as far as I can tell.I'm also not certain how to replace the functionality of
ExtendedHammerItem.isIn(ItemGroup)which overrode a removed vanilla method and may have been the only reason forHammerData.groupandHammerData.cachedGroupto exist.