Skip to content

[FIX] 게시글 찜 삭제 오류 수정 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjeongdong merged 2 commits into from
Jan 6, 2025
Merged

[FIX] 게시글 찜 삭제 오류 수정 #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dc4879
fix : 게시글 찜 삭제 오류 수정
jjeongdong Jan 6, 2025
e3e691c
fix : 오타 수정
jjeongdong Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/back/catchmate/domain/board/repository/BookMarkRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
public interface BookMarkRepository extends JpaRepository<BookMark, Long> {
boolean existsByUserAndBoardAndDeletedAtIsNull(User user, Board board);

Optional<BookMark> findByUserIdAndBoardId(Long userId, Long boardId);
Optional<BookMark> findByUserIdAndBoardIdAndDeletedAtIsNull(Long userId, Long boardId);

Page<BookMark> findAllByUserIdAndDeletedAtIsNull(Long userId, Pageable pageable);
}
2 changes: 1 addition & 1 deletion src/main/java/com/back/catchmate/domain/board/service/BookMarkServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public StateResponse removeBookMark(Long userId, Long boardId) {
Board board = boardRepository.findById(boardId)
.orElseThrow(() -> new BaseException(ErrorCode.BOARD_NOT_FOUND));

BookMark bookMark = bookMarkRepository.findByUserIdAndBoardId(user.getId(), board.getId())
BookMark bookMark = bookMarkRepository.findByUserIdAndBoardIdAndDeletedAtIsNull(user.getId(), board.getId())
.orElseThrow(() -> new BaseException(ErrorCode.BOOKMARK_NOT_FOUND));

bookMark.delete();
Expand Down
Loading