rename attributes added by natchez-http4s to follow OTel semantic conventions #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now supports using http.response.status_code, which is the key required by the OTel semantic conventions.
atoivonen
approved these changes
Dec 19, 2025
Member
Author
|
FYI, this is what the trace map looked like when the inferred segments were being added: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following standards is generally a good thing, but especially here, because with these changes, X-Ray should start displaying a lot more useful information in its UI: (highlighted in orange)
The trace map is also improved, showing the correct association from client to server:
Some of this may be able to be removed if typelevel/natchez-http4s#148 is merged.