Add support for halting execution plans #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
added a commit
to adamruzicka/foreman-tasks
that referenced
this pull request
Jan 28, 2022
Contributor
|
This sounds like a nice feature, but I do not feel comfortable enough to ellaborate on the consequences here... |
adamruzicka
added a commit
to adamruzicka/foreman-tasks
that referenced
this pull request
Jul 28, 2022
adamruzicka
added a commit
to adamruzicka/foreman-tasks
that referenced
this pull request
Aug 19, 2022
adamruzicka
added a commit
to adamruzicka/foreman-tasks
that referenced
this pull request
Apr 4, 2024
Up until now, Dynflow only had support for clean cancellation. Upon cancellation a cancel event was sent to all cancellable suspended and running steps and it was the action's responsibility to cancel itself. However, there were actions which just weren't cancellable at all. This commit adds support for halting execution plans. The actions are completely unaware of this, on halt dynflow just destroys its internal state about a given execution plan and turns it to stopped state. It does not remove running steps from workers as we currently don't have any real means of doing so. Any pending events will be rejected. In other words, halting an execution plan ensure it will not run any further.
It is the caller's responsibility to not try to halt an already stopped execution plan.
Contributor
|
@adamruzicka if you'd like me to give it another try, I can do a review here. I've improved my code reading skills and I've learned YOLO, so I'd be happy to merge after a proper review |
Contributor
Author
|
I was about to merge this myself in the upcoming weeks, but I'll never say no to another pair of eyes on a pr so if you could, I'd be grateful for that |
ezr-ondrej
approved these changes
May 27, 2024
Contributor
ezr-ondrej
left a comment
ezr-ondrej
left a comment
There was a problem hiding this comment.
Overall looks pretty well designed :)
There is one too many halted flags to my taste and I'm unsure if the clean-up is all correct, but looks like it! :)
+1 from me FWIW.
Contributor
Author
|
Thank you @ezr-ondrej ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, Dynflow only had support for clean cancellation. Upon cancellation
a cancel event was sent to all cancellable suspended and running steps and it
was the action's responsibility to cancel itself. However, there were actions
which just weren't cancellable at all.
This commit adds support for halting execution plans. The actions are completely
unaware of this, on halt dynflow just destroys its internal state about a given
execution plan and turns it to stopped state. It does not remove running steps
from workers as we currently don't have any real means of doing so. Any pending
events will be rejected. In other words, halting an execution plan ensure it
will not run any further.