Drop optional field from Halt request variant #449
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not used anywhere. Previously we were leaving it unset, which was fine in single-process scenarios (such as tests and development environments), but failed in cases where the request took a round trip through the database.
pondrejk
approved these changes
Sep 5, 2025
pondrejk
left a comment
pondrejk
left a comment
There was a problem hiding this comment.
checked via foreman_tasks/api/tasks/bulk_stop endpoint, it now halts tasks as expected
Contributor
Author
|
Thank you @pondrejk ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not used anywhere. Previously we were leaving it unset, which was fine in single-process scenarios (such as tests and development environments), but failed in cases where the request took a round trip through the database.