Generalize weighted z-star coordinate#100
Generalize weighted z-star coordinate#100cbegeman wants to merge 6 commits intoE3SM-Ocean-Discussion:masterfrom
Conversation
|
This PR is functionally similar to E3SM-Project#5254, except that formulation encountered failures with gnu compilers on chrysalis detailed here E3SM-Project#5564. |
|
So far, this PR has small diffs on the following tests:
|
cbegeman
force-pushed
the
ocn-bugfix-zstar-isc-gnu
branch
from
f9d2573 to
f5fdf44
Compare
|
@xylar This case ran successfully ( |
| newThickness ! temp used during min/max adjustment | ||
| weightSum, &! sum of weights in vertical | ||
| restingThicknessSum, &! total resting thickness | ||
| restingThicknessDiff, &! difference from total resting thickness |
There was a problem hiding this comment.
Could we call restingThicknessDiff something else (like restingSSH)? It isn't clear what it's the difference with respect to.
Could you share more specifically (perhaps on Slack) what trouble you're running into? I just rebuilt my conda environment and MPAS-Ocean with gnu on Chrysalis and so far I'm having no trouble running the Update: the Let me know what I can do to help debug the troubles you're having. |
…tween initial wct and restingThicknessSum
cbegeman
force-pushed
the
ocn-bugfix-zstar-isc-gnu
branch
from
678f5c6 to
8176242
Compare
2 participants
This PR increases the generalizability of vertical coordinates by relaxing the assumption that
restingThicknessspansssh=0tobottomDepth. As such, it is tangentially related to inactive top cells. The change affects cases whereconfig_ALE_thickness_proportionality='restingThickness_times_weights', which is the default.[non-BFB]