Support wetting-and-drying with RK4 and subglacial thin film#119
Draft
cbegeman wants to merge 4 commits intoE3SM-Ocean-Discussion:masterfrom
Draft
Support wetting-and-drying with RK4 and subglacial thin film#119cbegeman wants to merge 4 commits intoE3SM-Ocean-Discussion:masterfrom
cbegeman wants to merge 4 commits intoE3SM-Ocean-Discussion:masterfrom
Conversation
Collaborator
|
Thanks @cbegeman, this is really helpful! |
4 tasks
a167dc8 to
b4a72a1
Compare
b4a72a1 to
d7ab022
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has two components:
For (1),
landIcePressureApplied = min(landIcePressure, landIcePressureFloatation).landIcePressureFloatation = rho_sw * g * ssh_minwheressh_min = bottomDepth - h_critandh_critis the minimum thickness according to the wetting-and-drying algorithm. In plain language, in hydrostatic equilibrium, land ice pressure cannot cause the water column to thin below the minimum thickness.rho_swis the reference ocean density so our hydrostatic estimate forssh_mincould be quite off where the local ocean density deviates fromrho_sw. For this reason, we also add the option to allow land ice pressure that exceeds this value by some fixed amount. I have seen some threshold behavior where simulations crash above a certain amount of excess pressure around 10m-equivalent ice thickness.For (2), we estimate the thickness of the water column if we were to use the full ice pressure, applying a hydrostatic dSSH from the difference between
landIcePressureandlandIcePressureFloatationto the dynamic SSH. By incorporating the dynamic SSH we allow ungrounding only of cells that are already close to floatation.There is a 3rd component which may be added to this PR but is not part of the minimum necessary changes to support RK4, wetting-and-drying, and a subglacial thin film. That is the update of the
landIceFloatingMask/landIceFloatingFractionto allow melting in ungrounded regions. In the near term, we decided that would be cells wherelandIceDraft > -bottomDepth.