Fix bugs related to vertical lagrangian remapping#130
Draft
cbegeman wants to merge 25 commits intoE3SM-Ocean-Discussion:masterfrom
Draft
Fix bugs related to vertical lagrangian remapping#130cbegeman wants to merge 25 commits intoE3SM-Ocean-Discussion:masterfrom
cbegeman wants to merge 25 commits intoE3SM-Ocean-Discussion:masterfrom
Conversation
cbegeman
force-pushed
the
ocn/fix-vertical-remap
branch
from
ddce143 to
cef0cf6
Compare
Collaborator
Author
TestingInternal wave test case with VLR active: Differences are larger than machine precision, normalVelocity O(1e-5) m/s, layerThickness O(1e-2) m but behavior is similar: Old New |
cbegeman
force-pushed
the
ocn/fix-vertical-remap
branch
from
945ff66 to
65b5c94
Compare
…Velocity minus normalVelocity. Needs clean-up
cbegeman
force-pushed
the
ocn/fix-vertical-remap
branch
from
65b5c94 to
d73fda7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The critical change here is that remapping needs to be called at the beginning of split time integration in order to work in coupled model configurations, whereas before it occurred during Stage 3 of the split time integration schemes (after baroclinic and barotropic iterations).
The second important change is calling
ocn_ALE_thicknessfrom withinocn_vert_regridto ensure consistency in vertical coordinate.layerThicknessTargetrefers to the output of the vertical coordinate routine, which is used to compute the vertical velocity.There was also a need to change loop limits to nCellsAll rather than nCellsHalo in
mpas_ocn_thick_ale.F.