Add MCT ice-shelf melt and interface-temperature coupling between MPAS-Ocean and MALI#139
Open
xylar wants to merge 34 commits intoE3SM-Ocean-Discussion:masterfrom
Open
Add MCT ice-shelf melt and interface-temperature coupling between MPAS-Ocean and MALI#139xylar wants to merge 34 commits intoE3SM-Ocean-Discussion:masterfrom
xylar wants to merge 34 commits intoE3SM-Ocean-Discussion:masterfrom
Conversation
…xToLandIce is now the total flux between ocn and glc
…ription and other coupler variables
…ssure to new config option
Instead of computing the ice-shelf freshwater flux (Fogx_qicelo and Fogx_qiceli) in the coupler when we are running with coupled ocn-glc configurations, pass the flux from ocn through the coupler to glc (Foxo_ismw). All references to Fogx_qicelo and Fogx_qiceli have been removed except in prep_glc_calculate_subshelf_boundary_fluxes(), which will be removed separately.
This requires adding Foxo_frazil_li to the glc fluxes.
This merge adds `landIceInterfaceTracers` to both diagnostic variables and time averaging so that they can be passed through the coupler. `landIceBoundaryLayerTracers` and `landIceTransferVelocities` are removed from coupler averaging, since they are no longer passed to the coupler.
This includes removing the function for computing ice shelf freshwater and heat fluxes as well as all the associated input and output coupler variables.
This is no longer supported in MPAS-Ocean so no need to have a coupler variable for it.
Send average MPAS-Ocean value to the coupler. We're not yet sending it on to MALI.
This field gets set from the coupler So_intrt field (converted from C to K). This merge also removes the unused OceanDensity local variable.
Fix units for `avgLandIceInterfaceTemperature` and `avgTemperatureSurfaceValue` in registry.
This merge switches to `So_tfrz_isf` coupled variable name and adds `So_liflfrac` as a variable used to renormalize the ice-ocean interface temperature by.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR advances the MPAS-Ocean to MALI ice-shelf coupling path in the MCT driver.
It adds the remaining coupler plumbing needed to pass shelf melt/frazil mass fluxes and ice-ocean interface temperature from MPAS-Ocean to MALI, returns conductive heat flux from MALI back to MPAS-Ocean, and fixes several bugs in the existing implementation.
We're implementing this first in MCT. Some shared coupler field-list changes touch MOAB-related files, but the full set of MOAB have not yet been implemented in this PR.
Main changes
avgLandIceInterfaceTemperatureto Kelvin before couplingfloatingBasalMassBalFlgg_hflxiceOceanInterfaceTemperatureas the floating basal thermal boundary in MALI, with fallback to the existing depth-based freezing temperature when the imported value is invalidBug fixes
This PR also fixes a few bugs in the in-progress implementation:
So_tfrz_isfandSo_liflfraclookup to usex2gindices in MALImpaso_cpl_indices.FWhat is still not yet included
The following work is not yet addressed in this PR:
Fogx_qicehi