Addition of TRiSK++ to ocean dynamical core#9
Open
scalandr wants to merge 23 commits intoE3SM-Ocean-Discussion:masterfrom
Open
Addition of TRiSK++ to ocean dynamical core#9scalandr wants to merge 23 commits intoE3SM-Ocean-Discussion:masterfrom
scalandr wants to merge 23 commits intoE3SM-Ocean-Discussion:masterfrom
Conversation
mark-petersen
force-pushed
the
scalandr/ocean/triskCV
branch
from
7c37b3c to
39d0cce
Compare
scalandr
force-pushed
the
scalandr/ocean/triskCV
branch
from
4bf2c9e to
40bdda9
Compare
mark-petersen
force-pushed
the
scalandr/ocean/triskCV
branch
2 times, most recently
from
f613fa4 to
722fe05
Compare
scalandr
force-pushed
the
scalandr/ocean/triskCV
branch
from
722fe05 to
42c4f33
Compare
Collaborator
|
@scalandr thanks for looking at these changes to |
…ntialVelocity (with weightsOnEdge_lsqr)
scalandr
force-pushed
the
scalandr/ocean/triskCV
branch
from
bf98f3d to
7b8a983
Compare
mark-petersen
pushed a commit
that referenced
this pull request
May 31, 2023
cee/15.0.0 with GPU MPI buffers can crash in a system lib like this: #4 0x00007fffe159e35b in (anonymous namespace)::do_free_with_callback(void*, void (*)(void*)) [clone .constprop.0] () from /opt/cray/pe/cce/15.0.0/cce/x86_64/lib/libtcmalloc_minimal.so.1 #5 0x00007fffe15a8f16 in tc_free () from /opt/cray/pe/cce/15.0.0/cce/x86_64/lib/libtcmalloc_minimal.so.1 #6 0x00007fffe99c2bcd in _dlerror_run () from /lib64/libdl.so.2 #7 0x00007fffe99c2481 in dlopen@@GLIBC_2.2.5 () from /lib64/libdl.so.2 #8 0x00007fffea7bce42 in _ad_cray_lock_init () from /opt/cray/pe/lib64/libmpi_cray.so.12 #9 0x00007fffed7eb37a in call_init.part () from /lib64/ld-linux-x86-64.so.2 #10 0x00007fffed7eb496 in _dl_init () from /lib64/ld-linux-x86-64.so.2 #11 0x00007fffed7dc58a in _dl_start_user () from /lib64/ld-linux-x86-64.so.2 #12 0x0000000000000001 in ?? () #13 0x00007fffffff42e7 in ?? () #14 0x0000000000000000 in ?? () Work around this by using cee/14.0.3.
xylar
pushed a commit
that referenced
this pull request
Nov 8, 2023
Namelist mods floediam floeshape
xylar
pushed a commit
that referenced
this pull request
Nov 14, 2025
…t#7866) This is changing code that is widely used and has been unchanged for a very long time, so I'm adding a lot of reviewers. Feel free to add more. I stumbled across this code when trying to debug a weird eamxx failure: I observed the following symtoms: If you look at components/elm/src/main/reweightMod.F90, you'll see the line SHR_ASSERT(bounds%level == BOUNDS_LEVEL_CLUMP, errMsg(__FILE__, __LINE__)) which causes this error: 1: free(): invalid pointer ... 0: #8 0x4c7e3ab in __shr_log_mod_MOD_shr_log_errmsg 0: at /pscratch/sd/a/acmetest/E3SM/share/util/shr_log_mod.F90:78 0: #9 0x914149 in __reweightmod_MOD_reweight_wrapup 0: at /pscratch/sd/a/acmetest/E3SM/components/elm/src/main/reweightMod.F90:48 0: #10 0x17bda7d in __dynsubgriddrivermod_MOD_dynsubgrid_wrapup_weight_changes 0: at /pscratch/sd/a/acmetest/E3SM/components/elm/src/dyn_subgrid/dynSubgridDriverMod.F90:403 0: #11 0x17bf256 in __dynsubgriddrivermod_MOD_dynsubgrid_init._omp_fn.0 0: at /pscratch/sd/a/acmetest/E3SM/components/elm/src/dyn_subgrid/dynSubgridDriverMod.F90:150 I thought this was because the SHR_ASSERT was failing, but that's not the case (both bounds%level and BOUNDS_LEVEL_CLUMP are always 2). If I just comment this SHR_ASSERT out entirely, the test PASSES! The lowest line of code that triggers the free(): invalid pointer error is: shr_log_errMsg = 'ERROR in '//trim(file)//' at line '//toString(line) What I think is happening is that there is some memory corruption that is causing the freeing of the allocation done by toString to fail. So, this PR kind of sweeps that issue under the rug, but I do think it's better not to do dynamic allocations if you don't have to. The test PASSes with the changes in this PR. [BFB]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the way the kinetic energy is computed. Now kineticEnergyCell is mapped from kineticEnergyEdge and for the construction of kineticEnergyEdge new weightsOnEdge are computed based on a least-square approach. On init, a new subroutine that computes these weightsOnEdge_lsqr is called.