EAMxx: improve horiz/vert contraction tests #6897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahf708
added
enhancement
Testing
mahf708
commented
Jan 15, 2025
| for(int i = 0; i < dim0; ++i) { | ||
| for(int j = 0; j < dim1; ++j) { | ||
| for(int k = 0; k < dim2; ++k) { | ||
| mr3(i, j) += v1(i, k) * v2(i, j, k); | ||
| } | ||
| REQUIRE_THAT(rr3(i, j), Catch::Matchers::WithinRel(mr3(i, j), tol)); |
There was a problem hiding this comment.
@bartgol I decided to keep the manual unrolling stuff because I thought it is better to keep utils isolated in their testing (kinda with a reference of frame of basics) instead of using more advanced mathy construction
There was a problem hiding this comment.
Sounds good. Personally, I find mathy more readable than impl-rich loops with views access. After all, once the utils are tested, why not using them inside other tests?
But really, this is fine, it's just a matter of taste. :)
mahf708
changed the title
bartgol
approved these changes
Jan 15, 2025
bartgol
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imrpoves contraction testing by using catch2 matchers to allow for tolerance and expand contracted dimensions.
Fixes #6893