EAMxx: make SPA use DataInterpolation #6920
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartgol
force-pushed
the
bartgol/eamxx/spa-use-data-interpolation
branch
2 times, most recently
from
7aabbe9 to
87adc7b
Compare
We cannot pass "--rng-seed -123" as flag, so ensure that we have a POSITIVE seed
SCREAM_MPI_ON_DEVICE is *always* defined
Given that remap setup options started to increase too much, I added a RemapData mini-struct, that customers need to pass
Allow to pass in the reference time stamp rather than reading it in from the input files
Also remove the unit tests, since SPA is simply a wrapper of a DataInterpolation instance
bartgol
force-pushed
the
bartgol/eamxx/spa-use-data-interpolation
branch
from
87adc7b to
0bb87be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
DataInterpolation:
SPA:
This PR will be rebased on master once #6914 and #6919 are merged.