EAMxx: add field utility to scale with inverse of input field #6960
+132
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartgol
added
BFB
bartgol
force-pushed
the
bartgol/eamxx/field-scale-inv
branch
from
833436e to
cd9f86f
Compare
AaronDonahue
approved these changes
Jan 30, 2025
AaronDonahue
approved these changes
Jan 31, 2025
bartgol
force-pushed
the
bartgol/eamxx/field-scale-inv
branch
from
91f7383 to
e1469f2
Compare
|
I forced a rebase on master due to conflicts with next. I will merge to next/master as soon as CI passes, without waiting for aaron to review again. |
bartgol
added a commit
that referenced
this pull request
Jan 31, 2025
Similar to the existing Field::scale. It helps making unit tests (or non-perf critical code) easier to read. [BFB] Signed-off-by: Luca Bertagna <lbertag@sandia.gov>
bartgol
force-pushed
the
bartgol/eamxx/field-scale-inv
branch
from
e1469f2 to
7adde68
Compare
|
@bartgol , is this good to go in now? |
|
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the existing
Field::scale. It helps making unit tests (or non-perf critical code) easier to read.[B4B]