Skip to content

add optional wave height input to subroutines in icepack that calculate wave heights #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darincomeau merged 15 commits into from
Nov 18, 2025
Merged

add optional wave height input to subroutines in icepack that calculate wave heights #40

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
992f7ce
add optional wave height input to wavefracspec
erinethomas Jul 23, 2025
b32a55f
add wave height optional argument to wave_dep_growth
erinethomas Jul 30, 2025
e75110b
bug fix
erinethomas Aug 1, 2025
a79a5f3
adding units to sig. wave height variable comments
erinethomas Nov 4, 2025
4744095
adding wave_height_type namelist option to control wave_height_coupling.
erinethomas Nov 5, 2025
58a7e56
clean up coupled wave_height code options
erinethomas Nov 12, 2025
32e7295
fix abort when noe wave hiehgt data provided in fsd
erinethomas Nov 12, 2025
e3079de
bug fix
erinethomas Nov 12, 2025
bca5def
tidy up
erinethomas Nov 12, 2025
c89d3a2
bug fix to abort
erinethomas Nov 12, 2025
9c78389
clean up
erinethomas Nov 13, 2025
de39323
new comment for clarity
erinethomas Nov 13, 2025
38f0192
modify fsd tests for new wave_height_type
erinethomas Nov 13, 2025
53fcc4a
fix namelist checking for wave_height_type
erinethomas Nov 13, 2025
2b94b15
add endif
erinethomas Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions columnphysics/icepack_fsd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ subroutine fsd_add_new_ice (n, &

if (wave_spec) then
if (wave_sig_ht > puny) then
call wave_dep_growth (wave_spectrum, &
call wave_dep_growth (wave_spectrum, wave_sig_ht, &
wavefreq, dwavefreq, &
new_size)
if (icepack_warnings_aborted(subname)) return
Expand Down Expand Up @@ -774,7 +774,7 @@ subroutine fsd_add_new_ice (n, &

if (wave_spec) then
if (wave_sig_ht > puny) then
call wave_dep_growth (wave_spectrum, &
call wave_dep_growth (wave_spectrum, wave_sig_ht, &
wavefreq, dwavefreq, &
new_size)
if (icepack_warnings_aborted(subname)) return
Expand Down Expand Up @@ -816,7 +816,7 @@ end subroutine fsd_add_new_ice
!
! authors: Lettie Roach, NIWA/VUW
!
subroutine wave_dep_growth (local_wave_spec, &
subroutine wave_dep_growth (local_wave_spec, wave_height, &
wavefreq, dwavefreq, &
new_size)

Expand All @@ -829,6 +829,9 @@ subroutine wave_dep_growth (local_wave_spec, &
wavefreq, & ! wave frequencies (s^-1)
dwavefreq ! wave frequency bin widths (s^-1)

real(kind=dbl_kind), intent(in), optional :: &
wave_height

integer (kind=int_kind), intent(out) :: &
new_size ! index of floe size category in which new floes will grow

Expand All @@ -844,7 +847,11 @@ subroutine wave_dep_growth (local_wave_spec, &

integer (kind=int_kind) :: k

w_amp = c2* SQRT(SUM(local_wave_spec*dwavefreq)) ! sig wave amplitude
if (present(wave_height)) then
w_amp = p5 * wave_height ! amplitude is 1/2 sig wave hight
else
w_amp = c2* SQRT(SUM(local_wave_spec*dwavefreq)) ! sig wave amplitude
endif
f_peak = wavefreq(MAXLOC(local_wave_spec, DIM=1)) ! peak frequency

! tensile failure
Expand Down
13 changes: 11 additions & 2 deletions columnphysics/icepack_wavefracspec.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ subroutine icepack_step_wavefracture(wave_spec_type, &
dt, nfreq, &
aice, vice, aicen, &
wave_spectrum, wavefreq, dwavefreq, &
trcrn, d_afsd_wave)
trcrn, d_afsd_wave, wave_height)


character (len=char_len), intent(in) :: &
Expand Down Expand Up @@ -214,6 +214,9 @@ subroutine icepack_step_wavefracture(wave_spec_type, &
real (kind=dbl_kind), dimension(:), intent(out) :: &
d_afsd_wave ! change in fsd due to waves

real (kind=dbl_kind), intent(in), optional :: &
wave_height ! wave height

real (kind=dbl_kind), dimension(nfsd,ncat) :: &
d_afsdn_wave ! change in fsd due to waves, per category

Expand Down Expand Up @@ -254,7 +257,13 @@ subroutine icepack_step_wavefracture(wave_spec_type, &
! if all ice is not in first floe size category
if (.NOT. ALL(trcrn(nt_fsd,:).ge.c1-puny)) then

local_sig_ht = c4*SQRT(SUM(wave_spectrum(:)*dwavefreq(:)))
! Add option to use wave height from wave model
if (present (wave_height)) then
local_sig_ht = wave_height
else
local_sig_ht = c4*SQRT(SUM(wave_spectrum(:)*dwavefreq(:)))
endif

! do not try to fracture for minimal ice concentration or zero wave spectrum
! if ((aice > p01).and.(MAXVAL(wave_spectrum(:)) > puny)) then
if ((aice > p01).and.(local_sig_ht>0.1_dbl_kind)) then
Expand Down
Loading