forked from CICE-Consortium/Icepack
-
Notifications
You must be signed in to change notification settings - Fork 4
Merge Icepack #c17597c for resynchronization #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 31 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
fa56e7e
Update Perlmutter Port, switch to cce/17.0.0, gnu/12.3, and intel/202…
apcraig 43ead56
hocn calculation and flushing velocity issue (#504)
davidclemenssewall 9f4b99a
Update derecho gnu, add code coverage capability via lcov (#510)
apcraig 352e6bc
Update copyright to 2025 (#514)
apcraig 619d06d
fix sfc_flux argument order in therm_vertical (#513)
kieranricardo b3b5127
Corrects negative silicate values (#519)
njeffery 51695d0
MDF/MOSAiC forcing options (#500)
davidclemenssewall 5feadd0
Deprecate zsalinity (#521)
apcraig dc769c7
Update institutions in distribution policy document and authors in ze…
eclare108213 6592646
Update set_version_number.csh to update .zenodo.json file (#523)
apcraig cfdf8cc
Update Copyright and License, update version to 1.5.1 (#524)
apcraig 33352a2
Use proleptic gregorian in icepack (#525)
anton-seaice ac57a1c
Add GEOS coupling capability including heatflux and massflux modifica…
apcraig f61be9a
Final updates for GEOS changes. (#526)
apcraig ec7ad9c
Move three snow grain radius parameters to namelist (#529)
njeffery 67f17ab
A new sea level pond scheme. (#515)
dabail10 4469e2e
Update ponds diagnostics and names (#530)
apcraig b91f1dd
Add David Clemens-Sewall and Bin Zhao to zenodo (#531)
apcraig 842a15e
Fix nag compiler error about kind=8 declaration, change to kind=dbl_k…
apcraig 6bc2d0a
Fix commas in zenodo template (#533)
apcraig b7c4dc5
json updates (#534)
eclare108213 6a5c51e
Add vicen, vsnon to zap_small_areas (#536)
NickSzapiro-NOAA f9789c2
Update Copyright (#537)
apcraig a5b5ebe
Update Copyright in zenodo json file (#538)
apcraig 3c2eeb5
Remove unused _init variables (#539)
eclare108213 7ee2266
Update the qstat job completion checks to use (#541)
apcraig 4954a6f
Fix Tsnice calculation (#542)
dabail10 eedb519
Zap residual ice (#543)
eclare108213 0bcde25
external wave height option (#545)
eclare108213 c17597c
merge consortium main into e3sm branch
eclare108213 d5d603e
remove duplicate declaration statement
eclare108213 3e649ed
add end-quote in index documentation (#547)
eclare108213 fb8ccc1
clarify uv and par comments and doc (#549)
eclare108213 fc9b0d1
Merge branch 'eclare/seaice/icepack_20260114' into eclare/seaice/e3sm…
eclare108213 2f31ee3
Update version to 1.5.3 (#550)
apcraig 3a320c4
Merge branch 'eclare/seaice/icepack_20260114' into eclare/seaice/e3sm…
eclare108213 daa4163
enforce minimum snow grain radius (#552)
eclare108213 ad25782
Merge branch 'eclare/seaice/icepack_20260114' into eclare/seaice/e3sm…
eclare108213 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The abbreviated commenting of fswthrun_uvrdr, fswthrun_uvrdf, fswthrun_pardr, and fswthrun_pardf needs to be expanded here. ">700nm vis uvr" appears to be an oxymoron, and I could not find a clear language explanation of "400-700nm vis par".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expanded definitions are in the documentation file
icepack_index.rst(which for some reason is not being rendered in readthedocs -- will need to investigate):https://github.com/E3SM-Project/Icepack/pull/42/changes#diff-e85f96fcb99c37298c8ac35b5e6e0f6d440c27fcce88e26306c627951b26c866R194-R200
These changes came in with CICE-Consortium#518, where the PR header info says
So it sounds like
uvris the part of the visible spectrum that is notpar... but the word 'ultraviolet' does not make sense with 'visible', I agree. Pinging @zhaobin74 for further clarification.