-
Notifications
You must be signed in to change notification settings - Fork 2
Description
First of all, thanks for this excellent exporter.
Unfortunately despite saying that "exporter will continue running but scrapes may fail or produce incorrect data", it is actually not even trying to call nvme tool to gather data.
Any lower version is currently treated in the same way as lack of nvme command, effectively setting validationState.isValid=false, which results in skipping device query due to validation failure in GetDevices() function in pkg package.
I did compile my own binary with const _minimumSupportedVersion = "2.3" and it seems to work well.
There are some labels missing (like generic_path), but I believe it is not critical issue.
There are many appliances like Proxmox or TrueNas built on Debian 12, which by default ships with nvme-cli 2.3 only, and it's not always possible to install newer version, so allowing to actually run nvme_exporter with nvme-cli 2.3 would be greatly beneficial to the community.