Added health.consumer.goapp #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to #10.
It adds the new folder
examples/health.consumer.goapp/which implements a Go client consuming the HealthCheck example remote service.I implemented this example following https://grpc.io/docs/languages/go/quickstart/. However, this was the first time I was writing code with Go, so some conventions might not be followed.
As stated in the
examples/health.consumer.goapp/readme.mdfile, I had to add thego_packageoption to thehealth.protofile.@scottslewis feel free to edit the pull request as required or to tell me what should be edited before it's merged (e.g. update the root's readme.md?). If you don't want this example at all for any reason (i.e. reject the pull request), it's fine to me too!
// Edit: Btw. I used Visual Studio Code for development (I started by watching https://www.youtube.com/watch?v=1MXIGYrMk80). It would have been nice to be able to develop everything in Eclipse (i.e. to have a .project file in the
health.consumer.goappfolder) so that developers can import all HealthCheck related code (API, examples, ...) into the Eclipse Workspace. But all I found was Goclipse which is no longer maintained.