A few fixes (#807 #820) and changes (matching a few in-game numbers) #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calculations, matching some in-game numbers
Collaborator
|
Thanks for this, I haven't had a chance to properly look at this yet, despite trying (Busy IRL). I will take a look as soon as I can. There was previously an issue where the fuel tank mass was/wasn't being taken into account in different circumstances and it was screwing with the mass calculations and Distance calculations and I fixed that previously, so will need to take a close look at what this is actually doing. |
Author
|
Eh, I just noticed that I messed up spacing (especially in Calculations.js). Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #807, Fixes #820
Fixes:
• Fuel tanks were being included as extra mass in 'unladenMass', causing the calculations to use fuel mass value twice. Separated fuel from 'unladenMass' as 'outfittedMass' and utilized it in place to avoid the calculation issues.
Changes:
• 'reserveFuelCapacity' isn't included in FSD range calculations except the Unladen ones. This allows the jump range values on the website to match the in-game ones.
• Similarly, Unladen/Laden Mass displays include 'reserveFuelCapacity' to match the in-game values now. Unsure if this actually is used in calculations, but since the above fix allowed some values to match, decided to match this one as well.
In-game values and fix result for this build:
Profile comparison for live (orange) & fix (blue) for this fuel tank loaded build:
