Make sure the full directory name is replaced in eb_hooks.py, replace placeholders before comparing what is shipped
#14
+34
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2 |
|
New job on instance
|
|
This is not correct, this is touching unnecessary files. |
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2 |
|
New job on instance
|
ocaisa
changed the title
eb_hooks.pyeb_hooks.py, replace placeholders before comparing what is shipped
|
The test step was failing in #14 (comment) due to
|
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2 |
|
New job on instance
|
The installation script is working as intended, just need to make a fake change to the hooks to get it into a tarball. |
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2 |
|
New job on instance
|
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2 |
|
New job on instance
|
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2 |
|
New job on instance
|
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2 |
|
New job on instance
|
|
Ok, this is ready to go: [ocaisa@login1 ~]$ tar -zxvf /project/def-users/SHARED/jobs/finished/70024/eessi-2023.06-software-linux-x86_64-amd-zen2-17500768900.tar.gz
2023.06/init/easybuild/eb_hooks.py
[ocaisa@login1 ~]$ grep errmsg 2023.06/init/easybuild/eb_hooks.py
errmsg = "EasyConfigs using toolchains based on GCCcore-12.2.0 are not supported for the Zen4 architecture.\\n"
errmsg += "See https://www.eessi.io/docs/known_issues/eessi-2023.06/#gcc-1220-and-foss-2022b-based-modules-cannot-be-loaded-on-zen4-architecture"
ec['modluafooter'] = 'if (not os.getenv("%s")) then LmodError("%s") end' % (env_varname, errmsg) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was basically a typo in #11
That PR also creates problems though through the use of
sed -ias this always updates the timestamps on the files, causing any file where it was used to also be shipped. Resolved this by creating a bash function that is more careful.Finally, that PR also "broke" the test script as that script was not correctly picking up the EESSI version, this is also fixed here.