-
Notifications
You must be signed in to change notification settings - Fork 12
add hook to avoid requiring ncurses static libraries for CMake built with system
toolchain
#81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eb_hooks.py
Outdated
|
||
if self.name == 'CMake': | ||
if self.toolchain.name == 'system': | ||
print_msg("Unset configopts to use ncurses library from the EESSI compatibility layer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use self.log.info
here, or print_msg
with log=self.log
if you want to be very verbose about this.
I would also log what the previous value of configopts
was, so it's clear what's being wiped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boegel I have updated the log messages as suggested
… with system compiler
only remove `-DCURSES_.*_LIBRARY` configure options when building CMake…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tested to verify that it works as intended
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
New job on instance
|
staging PR merged... |
@boegel we should also build and deploy this for 2025.06? |
Yes, exactly. ❤️ CI |
bot: build repo:eessi.io-2025.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
New job on instance
|
staging PR for 2025.06 merged |
system
toolchain
this hook fixes issue EESSI/software-layer#1175
now I can build cmake on top of EESSI but I noticed something weird. I don't know why
configopts
are not completely removed. This is the original easyconfig:but when building with this hook I see this (notice the
--
after--parallel=16
I am also not sure if I should use
print_msg()
or something different likelog.info
orlog.debug