Skip to content

Fix the excluded peaks in WatershedLungspace #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psomhorst merged 2 commits into from
Sep 25, 2025
Merged

Fix the excluded peaks in WatershedLungspace #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28768d9
Fix definition of excluded peaks in WatershedLungspace
psomhorst Sep 9, 2025
3ae408a
Add test asserting the number of included and excluded peaks sums to …
psomhorst Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eitprocessing/roi/watershed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def apply( # noqa: PLR0915

included_marker_indices = np.isin(peaks_loc_int, markers_inside_tiv_mask)
included_peaks = np.argwhere(included_marker_indices)
excluded_peaks = np.argwhere(~included_marker_indices)
excluded_peaks = np.argwhere(peaks_loc_bool & ~included_marker_indices)

included_watershed_regions = np.where(included_region, watershed_regions, np.nan)

Expand Down
2 changes: 2 additions & 0 deletions tests/test_watershed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ def test_watershed_captures(draeger1: Sequence):
]:
assert key in captures, f"captures should have a '{key}' entry"

assert len(captures["local peaks"]) == len(captures["included peaks"]) + len(captures["excluded peaks"])


def test_watershed_no_amplitude():
eit_data = EITData(
Expand Down