fix: discover models from configured providers#904
Open
Asunfly wants to merge 1 commit into
Open
Conversation
a3fec6d to
5bdfa76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.providers.<name>entries.default_model,model.default, andmodel.model.key_envnames before reading environment variables.Why
Hermes Agent can load configurations where custom providers are declared under
providers, for example:The server config endpoint could read this shape, but
/api/hermes/available-modelsdid not expose the configured provider/model group. That left the model selector empty even though the active Hermes config was valid.Duplicate check
I checked existing related issues/PRs before opening this:
I did not find an existing issue/PR specifically covering
config.providers.<name>discovery in/api/hermes/available-models.Test plan
Local verification performed:
git diff --checknpx vitest run tests/server/model-visibility-controller.test.ts tests/server/config-helpers-file-lock.test.ts tests/server/health-controller.test.ts tests/client/models-store.test.tsnpm run buildLive verification against a local service using the newer Hermes config shape:
/healthreturned HTTP 200/api/hermes/profilesreturned HTTP 200/api/hermes/available-modelsreturned the configured custom provider group and its default model.