feat: productize War Room task evidence UX#931
Open
hangzaiqy27 wants to merge 1 commit into
Open
Conversation
Local source HEAD: 22ce9487c68698df4b6d55753ee9337079eed442
Owner
|
看了一下这个 PR,目前只新增了 这会导致 controller 里的: import * as warRoom from "../../services/hermes/war-room"在当前 main 上无法解析,单独合并大概率会 build/test 失败。 合并前建议补齐:
另外 controller 测试 mock 了 service,所以不会暴露缺失 service 的问题;建议补一个至少能覆盖 route/import wiring 的测试,避免这种断链。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR from fork branch. Evidence and project checkpoint are recorded under the Jarvis project evidence files. No credentials are included.