Skip to content

feat: productize War Room task evidence UX#931

Open
hangzaiqy27 wants to merge 1 commit into
EKKOLearnAI:mainfrom
hangzaiqy27:controlled-merge-v0.5.16-20260510_132949
Open

feat: productize War Room task evidence UX#931
hangzaiqy27 wants to merge 1 commit into
EKKOLearnAI:mainfrom
hangzaiqy27:controlled-merge-v0.5.16-20260510_132949

Conversation

@hangzaiqy27
Copy link
Copy Markdown

Automated PR from fork branch. Evidence and project checkpoint are recorded under the Jarvis project evidence files. No credentials are included.

Local source HEAD: 22ce9487c68698df4b6d55753ee9337079eed442
@EKKOLearnAI
Copy link
Copy Markdown
Owner

看了一下这个 PR,目前只新增了 packages/server/src/controllers/hermes/war-room.ts 和两组测试,但主干里没有看到对应的 packages/server/src/services/hermes/war-room.ts,也没有看到 route wiring。

这会导致 controller 里的:

import * as warRoom from "../../services/hermes/war-room"

在当前 main 上无法解析,单独合并大概率会 build/test 失败。

合并前建议补齐:

  • packages/server/src/services/hermes/war-room.ts 的实际实现
  • routes/hermes 下对应 API 路由注册
  • 如该 service/route 来自另一个 PR,请在描述里标明依赖关系和合并顺序

另外 controller 测试 mock 了 service,所以不会暴露缺失 service 的问题;建议补一个至少能覆盖 route/import wiring 的测试,避免这种断链。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants