Skip to content

Updated the pagination #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated the pagination #196

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e247ff4
Updated the pagination
dikshashukla455 Mar 27, 2022
4ee4d93
Update pagination.scss
dikshashukla455 Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/assets/scss/components/pagination.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
font-weight: bold;
}


Copy link
Member

@cyntss cyntss Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this addition

&-disabled {
color: $medium-gray;

Expand Down
10 changes: 8 additions & 2 deletions src/components/Pagination.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ const Pagination = (props) => {
}
}}
>
<EOS_KEYBOARD_ARROW_LEFT className='eos-icons eos-18' />
<EOS_KEYBOARD_ARROW_LEFT
color={`${currNumber <= 1 ? '#bbb' : ''}`}
Copy link
Member

@cyntss cyntss Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this solution. It is only changing the icon color, but the element will remain in the DOM. We need to skip the element injection in the DOM altogether

className='eos-icons eos-18'
/>
{`Prev`}
</span>
<div className='btn btn-pagination'>
Expand Down Expand Up @@ -77,7 +80,10 @@ const Pagination = (props) => {
}}
>
{`Next`}
<EOS_KEYBOARD_ARROW_RIGHT className='eos-icons eos-18' />
<EOS_KEYBOARD_ARROW_RIGHT
color={`${currNumber >= pages?.length ? '#bbb' : ''}`}
className='eos-icons eos-18'
/>
</span>
</div>
)
Expand Down