Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3139 +/- ##
==========================================
+ Coverage 73.15% 73.19% +0.03%
==========================================
Files 430 430
Lines 103937 104140 +203
Branches 16717 16738 +21
==========================================
+ Hits 76039 76221 +182
- Misses 27622 27643 +21
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fwesselm
approved these changes
Jul 9, 2026
fwesselm
left a comment
Collaborator
There was a problem hiding this comment.
@Opt-Mucca, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the crash from the instance in the comments of #2866
Explanation: While iterating over
singletonRows, presolving one of the singletons reduces multiple (probably identical ones) to empty rows. Despite them being reducedsingletonRowsis not updated (is waiting to be cleared). When the size 0 row is then processed, they are not yet deleted androwPresolvewill be called on them duringremoveRowSingletons. This will then result in a nested call ofremoveRowSingletons. This is all fine, until we're back at the original loop, where the counter is at something non-zero, e.g., 2, and the loop is continuing because2 != 0(the new size ofsingletonRowsfrom the nested call.Fix: I've just changed the
!=to a<.@zeddybot I'm assuming you're a bot, and a lot of the information wasn't necessary, but the instance was helpful and the issue was clearly explained.