Add experimental support for MPAS "convection-permitting" physics suite#448
Merged
kuanchihwang merged 13 commits intoESCOMP:developmentfrom Feb 27, 2026
Merged
Conversation
…rmitting" physics suite
When `base_idx` cannot be found by the `do` loop labeled `base_idx_loop` above, its value is set to `size(base_var_names) + 1`. Then, a few lines after, it is used again to access `base_var_names(base_idx)`, which constitutes an out-of-bound array access. CAM-SIMA will crash due to this. The solution is to `return` the subroutine early, and do not proceed any further.
nusbaume
approved these changes
Feb 11, 2026
Collaborator
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Thanks @kuanchihwang! I had one request for an additional comment, but otherwise this all looks good to me!
cacraigucar
requested changes
Feb 13, 2026
cacraigucar
approved these changes
Feb 18, 2026
Collaborator
|
I believe everything is approved now |
kuanchihwang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
None
Originator(s):
kuanchihwang
Descriptions (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
This PR enables CAM-SIMA to run with the "convection-permitting" physics suite from MPAS. You can use the
MPASCPcomponent set alias to create a simulation case (e.g.,./create_newcase --compset MPASCP ...). Be advised that the physics suite is still a work in progress. It is currently run with analytic initial condition, and without a proper land model for surface fluxes.Describe any changes made to the build system:
None
Describe any changes made to the namelist:
None
List any changes to the defaults for the input datasets (e.g., boundary datasets):
None
List all files eliminated and why:
None
List all files added and what they do:
None
List all existing files that have been modified, and describe the changes:
Regression tests:
Except for the known failing test above, all the other tests pass with respect to the last baseline,
sima0_11_001.