Skip to content

sima0_11_001: Bring in gpuized RRTMGP#451

Merged
peverwhee merged 123 commits intoESCOMP:developmentfrom
peverwhee:rrtmgp-gpu
Feb 13, 2026
Merged

sima0_11_001: Bring in gpuized RRTMGP#451
peverwhee merged 123 commits intoESCOMP:developmentfrom
peverwhee:rrtmgp-gpu

Conversation

@peverwhee
Copy link
Copy Markdown
Collaborator

@peverwhee peverwhee commented Dec 22, 2025

Tag name (required for release branches): sima0_11_001
Originator(s): peverwhee

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

  • Brings in GPUized schemes for RRTMGP via atmospheric physics
  • New mods to appease the NVHPC compiler in CAM-SIMA
  • Adds new test for GPUized RRTMGP (NOTE: currently using a CPU snapshot - until I can reliably run GPUized RRTMGP in CAM again)

Describe any changes made to build system: n/a

Describe any changes made to the namelist: n/a

List any changes to the defaults for the input datasets (e.g. boundary datasets): n/a

List all files eliminated and why: n/a

List all files added and what they do:

A    cime_config/testdefs/testmods_dirs/cam/outfrq_rrtmgp_derecho_gpu/shell_commands
A    cime_config/testdefs/testmods_dirs/cam/outfrq_rrtmgp_derecho_gpu/user_nl_cam
A    cime_config/testdefs/testmods_dirs/cam/outfrq_rrtmgp_derecho_gpu/user_nl_cpl
- Bring in test mods for GPUized RRTMGP test

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M    .gitmodules
M    src/physics/ncar_ccpp
M    ccs_config
- bring in updated atmospheric_physics and ccs_config submodules

M    src/core_utils/string_core_utils.F90
M    src/history/cam_history_support.F90
- mods to appease the nvhpc compiler

M    cime_config/cam_autogen.py
M    cime_config/cam_config.py
- build the appropriate dependencies for gpu runs

M    src/data/registry.xml
- update units and standard name to match new atmospheric physics tag

M    test/unit/python/*
- updates to match cam_autogen and cam_config mods above

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima: b4b, except for known NLFAIL for multiple history tape test

derecho/gnu/aux_sima: b4b

derecho/nvhpc/aux_sima: new baseline!

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

Courtney Peverley and others added 30 commits June 6, 2025 11:12
@peverwhee peverwhee self-assigned this Dec 22, 2025
@peverwhee peverwhee marked this pull request as ready for review February 4, 2026 04:42
@peverwhee peverwhee changed the title DRAFT: Bring in gpuized RRTMGP Bring in gpuized RRTMGP Feb 4, 2026
Copy link
Copy Markdown
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peverwhee!

Copy link
Copy Markdown
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peverwhee! This PR looks good to me, but I did have a question on the GPU snapshot files that I am hoping to get answered first before fully approving (as I thought the CAM GPU regression test fully runs now, although I could certainly be wrong).

@peverwhee peverwhee changed the title Bring in gpuized RRTMGP sima0_11_001: Bring in gpuized RRTMGP Feb 11, 2026
@peverwhee peverwhee merged commit a83b6f7 into ESCOMP:development Feb 13, 2026
16 checks passed
cacraigucar added a commit to nusbaume/CAM-SIMA that referenced this pull request Feb 13, 2026
sima0_11_001: Bring in gpuized RRTMGP (ESCOMP#451)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants