-
Notifications
You must be signed in to change notification settings - Fork 18
Implement CAM4 aquaplanet (QPC4) configuration #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 169 commits
Commits
Show all changes
171 commits
Select commit
Hold shift + click to select a range
6b03299
sima updates to get rrtmgp lw to generate caps
1f19dd0
latest atmos_phys tag
8ac539c
update atmos_phys submodule
bc961a0
cleanup; update atmos_phys hash
b9bdd6e
update git-fleximod
2a58a1e
latest atmos phys hash
084b8a4
merge to head of development
0b817f3
lw answers match cam for 2 timesteps using radiation
peverwhee a694713
use output variables for physics check
peverwhee c2a33d7
fix unit tests
peverwhee 8b9df0a
update check_data to not error when variable is not found
peverwhee b4331de
merge in output variable checking
peverwhee 50e5c2f
Merge remote-tracking branch 'origin/check-out-variables' into rrtmgp-lw
peverwhee 2752030
update atmos phys submodule
peverwhee 586a05f
Add 'var_subset_check' helper routine, with initial 'both present' ch…
nusbaume d7b4bbe
Add missing subroutine arguments.
nusbaume 63a5cbb
Add check for correct 'start' size, along with new unit test.
nusbaume de58bea
Add missing 'count' entry to test.
nusbaume eaf9264
Add missing space to error message, a 'count' size check, and an asso…
nusbaume f01ec4d
Add check and test for ensuring that start elements are within range.
nusbaume 098f4a0
Add missing Fortran character format.
nusbaume bd07e62
Add 'alloc_dims' output variable to ensure output variable is allocat…
nusbaume bf91195
Remove un-needed dimension index from allocate call.
nusbaume bc91c13
Add bounds checking for 'count' optional variable.
nusbaume 58a4840
Fix syntax error.
nusbaume e9018c3
Add subsetting when shape(count) matches shape(var), including unit t…
nusbaume 61389fd
Fix typo in subroutine call.
nusbaume ee4a3e9
Fix 'do_subset' syntax error.
nusbaume 249f87a
Fix bad subroutine name.
nusbaume c47dbe6
Flip error message and error code check for subset read test.
nusbaume 5175ea3
Add debugging output.
nusbaume a45e9d2
Cleanup debug output and modify start/count element range checks.
nusbaume 53780e7
Add subsetting to 2-D integer interface, add unit test, fix bad unit …
nusbaume 41fcd3d
Add 'singe value' subset test, and fix bad error message.
nusbaume 640a440
remove extraneous sum calls.
nusbaume 5c48075
Move non-subsetting rank check to 'var_subset_check', and add additio…
nusbaume d6fc649
Remove use of 'count' intrinsic to avoid name collision.
nusbaume de647be
Fix bad syntax in error message.
nusbaume 3385d54
Add subsetting calls to all non-scalar get_var calls.
nusbaume 76fc32a
Fix syntax error.
nusbaume ee27eb3
Adjust 'var_ndims' for charactervariables.
nusbaume 0c85688
Remove extra space in expected error message.
nusbaume dbc7354
Change error message text, and add additional unit tests.
nusbaume ac6fce9
Fix use statements in pFUnit Fortran code.
nusbaume 6f184f2
Move count bounds checking outside of output var check, and fix test …
nusbaume 73b75a3
Comment out real var subsetting test.
nusbaume 59775cc
Fix bad subsetting test, and partially uncomment 1D real subset test.
nusbaume 5b331ba
Uncomment 'end subroutine' line.
nusbaume 6402882
Remove comma from expected error message, and try reading press_ref v…
nusbaume ef23f22
Try 1D real subset test again.
nusbaume e829e94
Add 'pio_get_var' subsetting to remaining multi-dim get_var interfaces.
nusbaume 2776f7c
Print out press_ref values and change order.
nusbaume 574e71e
Change write statement to see if that fixes build issue?
nusbaume 4add51e
Removed commented-out assert statement.
nusbaume dfa8143
Add back-in original 'assert' statement.
nusbaume 23f6459
Formally declare expected values in real 1D subset test.
nusbaume 72844d0
Add ability to reduce output variable dimensionality via subsetting. …
nusbaume a20f592
Make output variable 3D to see if that works.
nusbaume 4f91699
Remove variable dimension reduction functionality (it doesn't appear …
nusbaume c2ff44c
Add error if user tries to subset a scalar variable, along with a rel…
nusbaume 77d876d
Add character variable subsetting unit test.
nusbaume 1625101
Fix character size assert check in subsetting test.
nusbaume da268b0
Fix syntax error in subset test.
nusbaume 37f1dd5
Add debugging output.
nusbaume 9cee38d
Try subsetting with character array length provided.
nusbaume 1728712
Increase 'var_ndims' by one to avoid incorrect error.
nusbaume dc0e3dc
Fix unit test assert statements, and update remaining character get_v…
nusbaume ab49b90
Fix error message in unit test.
nusbaume 0e5fb36
Remove fork/branch from Github Actions workflow.
nusbaume f65ec49
Remove leftover debugging code.
nusbaume 44729bd
merge in pio subsetting
peverwhee 3e6eeaa
update to dev tag
peverwhee 2cfe297
Update registry for gw_drag (orographic at least, CAM4)
jimmielin 5edf08a
Add host side support module for reading gravity wave ridge data.
jimmielin be2b7cc
Revise comment at head of module
jimmielin 5b62e05
Update ridge input standard names
jimmielin cc60fb5
Misc fix: 3-D input field read with dycore enabled; cam_in/cam_out fr…
jimmielin db335b5
Update cime_config/testdefs/testlist_cam.xml
jimmielin 573cf9a
Address review comments
jimmielin d347cf3
Updated to remove unused cam_in/cam_outs
jimmielin b572d80
Update git-fleximod to v1.0.2
nusbaume 5a32d0d
Update externals to match cam6_4_115.
nusbaume f367b49
Add debugging output to git-fleximod.
nusbaume 6cad15f
Print out git commands in fleximod.
nusbaume 3eaaf02
Remove debugging code.
nusbaume fcf380c
Update fleximod test and gitmodules file to match new CAM code/submod…
nusbaume 40cf4df
Add missed atmospheric_physics submodule update.
nusbaume 45328ea
Update ccs_config submodule.
nusbaume e340186
commit latest host side changes
peverwhee 5d404a9
merge in jesses externals updates
peverwhee a14e444
Add registry fields to read in pbuf fields to support GW CAM7.
jimmielin 917addd
Fix ridge read; clubb pbuf input vars have _gw suffix
jimmielin e3c31cf
Merge branch 'development' into hplin/gw_drag
jimmielin 4bc0bb9
Merge branch 'development' into hplin/gw_drag
jimmielin f9d9539
read coszrs from file; add dycore name to runtime_obj
peverwhee c114fe0
merge in development branch
peverwhee e5384b1
fix merge; add pbuf out fields to registry to be checked
peverwhee 7e29457
update atmos phys hash
peverwhee b1993e9
fix runtime object setter; add rrtmgp snapshot test
peverwhee 55f3b14
Merge branch 'development' into hplin/gw_drag
jimmielin 6c04924
Update do_molec_diff standard name to do_molecular_diffusion
jimmielin d47bb6f
Remove TBD from GW names
jimmielin 662630c
Merge branch 'development' into hplin/gw_drag
jimmielin 679e11f
Fix closing tag in registry.xml due to bad git merge
jimmielin 1984ac4
Calculate gw top taper in ref_pres to pass to scheme via metadata
jimmielin fa9acd0
remove redundant git-fleximod
peverwhee 3dd5cad
remove correct git-fleximod this time
peverwhee f182739
code cleanup
peverwhee a5b6dac
Merge remote-tracking branch 'ESCOMP/development' into rrtmgp-lw
peverwhee 92f7b76
remove final redundant git-fleximod files
peverwhee 01133f1
Add gravity wave CAM4 and CAM7 SDF tests
jimmielin edf0bd7
Remove UVTPS outfields from snapshot gw tests as sima_state_diagnosti…
jimmielin 0b21825
Provide frontgf, frontga from dycore (SE); remove from cam_runtime_op…
jimmielin f3aa434
Remove remnant gw_front(_igw) from runtime obj.
jimmielin 4594f2c
Add bnd_topo to FCAM7 testmods; port vorticity code from CAM to SE dy…
jimmielin 241994b
Fix port of vorticity code
jimmielin 9310678
Move vorticity (vort4gw) to physics_state
jimmielin d73235f
Initialize vorticity in se dycore; registry initial_value for clubb f…
jimmielin efd8964
Merge remote-tracking branch 'hplin/hplin/fixes_fadiab' into rrtmgp-lw
peverwhee a1ce363
Port cam6_4_126: Fix frontogenesis bug (SE dycore only) from CAM
jimmielin c963e10
remove unused diagnostic field; add handling for parameters in registry
peverwhee 42f912e
Change registry access protected to allocatable=parameter
jimmielin 581148b
clean up registry
peverwhee 1b4a5bb
add missing initial values to registry; removed unused fields
peverwhee 99ec7a7
update atmos phys hash
peverwhee 5d95cbf
Merge remote-tracking branch 'ESCOMP/development' into rrtmgp-lw
peverwhee c1de147
remove unnecessary reordering
peverwhee 31c9290
remove code that is no longer necessary
peverwhee ff7da37
merge up; use latest atmos phys hash
peverwhee 9098e4c
Bring in CAM4 physics test atmospheric_physics branch.
nusbaume 05cf588
Add 'usermods_dirs' directories with needed aquaplanet user_nl_cpl ch…
nusbaume 371ec95
Merge remote-tracking branch 'hplin/hplin/gw_drag' into cam4_aqua
nusbaume 0f97bbd
Merge remote-tracking branch 'courtney/rrtmgp-lw' into cam4_aqua
nusbaume 4a00f22
Add 'aquaplanet' config flag, remove un-used 'ocn' config option, and…
nusbaume 5cd4a1d
Update 'physconst' namelist values for a CAM4 aquaplanet configuration.
nusbaume 7fb46a0
Update ncar_ccpp submodule to bring in needed physics namelist mods f…
nusbaume 10008b1
Address review comments
jimmielin 7368353
Update src/physics/utils/gravity_wave_drag_ridge_read.F90
jimmielin 4f57c9f
Update atmospheric_physics submodule to bring in new radiative consti…
nusbaume d428a56
Update atmospheric_physics submodule to fix source code bugs.
nusbaume 575d319
Merge remote-tracking branch 'hplin/hplin/gw_drag' into cam4_aqua
nusbaume 315456f
Fix bug found during QPC4 experiment.
nusbaume c890650
Merge remote-tracking branch 'hplin/hplin/gw_drag' into cam4_aqua
nusbaume 467b911
Fix variable string length bug in PIO reader.
nusbaume d707796
Update atmos_phys external with RRTMGP register-phase fixes.
nusbaume 66b786a
Fix bug in model grid initialization, and add temporary MPAS grid.
nusbaume e2f0447
Add nitrogen deposition namelist and code updates needed for proper s…
nusbaume 0bb3cf4
Uncomment 'nextsw_cday' calls in the NUOPC cap.
nusbaume b23d19f
Skip consitutuents input read if variable not found on file and 'erro…
nusbaume d7bc6f0
Add constituents info to atm log file, and fix bad MPAS dyn_coupling …
nusbaume f25da30
Initial attempt at only using advected constituents in MPAS dycore.
nusbaume c260411
Only print constituents to log if root proc, and update atmos_phys ex…
nusbaume f0c69b2
Update atmos_phys submodule and fix bugs in order to properly set sur…
nusbaume 701ad8f
Fix namelist bug, update PEs file, and modify physics_read for better…
nusbaume e2ea6f3
Replace stub CAM4 regression test with aquaplanet CAM4 test.
nusbaume 1b0cf31
Remove leftover debugging code.
nusbaume c546193
Merge remote-tracking branch 'upstream/development' into cam4_aqua
nusbaume cc27c66
Fix bugs found after ESCOMP/CAM-SIMA gravity waves merge.
nusbaume 55d2c0b
Update all namelist 'pg' versions to 2.0, and fix failing python unit…
nusbaume 1f34f9e
Merge remote-tracking branch 'upstream/development' into cam4_aqua
nusbaume 6ad4ee9
Update external submodules to match cam6_4_143.
nusbaume ec795b7
Remove old git-fleximod copy.
nusbaume 92c3cd2
Squashed '.lib/git-fleximod/' content from commit 5796799
nusbaume da2dede
Merge commit '92c3cd25522756a66de038cae54de676c005acc4' as '.lib/git-…
nusbaume 8500ae1
Remove 'components/cism' directory that is no longer needed.
nusbaume 532f811
Fix bugs found during CCPP cap/namelist generation.
nusbaume 6894fa6
Update atmospheric_physics hash to avoid CAM7 test failure.
nusbaume 2f632fb
Update atmospheric_physics hash to use cleaned-up code and updated CA…
nusbaume 53b40bb
Fix issues found while opening the PR.
nusbaume bd2160f
Update submodule and XML files based on initial reviewer comments.
nusbaume 8258bf5
Update atmospheric_physics branch to use official repo.
nusbaume File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder to update with the ESCOMP hash/tag when it is available. Thanks!