Verbose physics data check: print out all checked variables#475
Merged
jimmielin merged 6 commits intoESCOMP:developmentfrom Mar 10, 2026
Merged
Conversation
cacraigucar
approved these changes
Mar 9, 2026
Collaborator
cacraigucar
left a comment
There was a problem hiding this comment.
My approval is mainly based as a functionality approval, as I tested this change a few weeks ago. I did look through the .F90 files and nothing jumped out at me as needing to be changed.
peverwhee
approved these changes
Mar 10, 2026
Collaborator
peverwhee
left a comment
There was a problem hiding this comment.
one small optional comment change, but otherwise looks good!
Member
Author
|
regression tests all pass subject to known failures - no baseline changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
Originator(s): @jimmielin
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
debug_output >= 1(DEBUGOUT_INFO) -- verbose level 2 is "too verbose" since it prints out the variables as they are being read, so it disrupts the output.A sample:
Describe any changes made to build system: N/A
Describe any changes made to the namelist: N/A
List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do: N/A
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
derecho/nvhpc/aux_sima: All PASS
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest:
Also includes the following change in #473:
Originator(s): billsacks, nusbaume
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
This is the same changes that are in ESCOMP/CAM#1492. To summarize:
Without this change, you couldn't run compsets with some non-CAM atm from a standalone CAM checkout.
Describe any changes made to build system:
M .config_files.xml
Describe any changes made to the namelist: N/A
List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do: N/A
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)M .config_files.xml