Check and enforce FLOAT64 snapshots for null dycore#478
Open
jimmielin wants to merge 4 commits intoESCOMP:developmentfrom
Open
Check and enforce FLOAT64 snapshots for null dycore#478jimmielin wants to merge 4 commits intoESCOMP:developmentfrom
jimmielin wants to merge 4 commits intoESCOMP:developmentfrom
Conversation
nusbaume
requested changes
Mar 15, 2026
Collaborator
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for the additional check @jimmielin! I just had one change request, which is basically that this check should only be done if we know we are running a snapshot test by examining the ncdata_check namelist variable as well.
… is not unset_path_str
nusbaume
approved these changes
Mar 15, 2026
Collaborator
nusbaume
left a comment
There was a problem hiding this comment.
Thanks @jimmielin! Everything looks good to me now, although I did have one (optional) variable declaration order request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
Originator(s): @jimmielin co-authored with
claude-opus-4.6Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
If the snapshot is not written out with
ndens=1on the CAM end it will cause incomprehensible answer differences comparing CAM and CAM-SIMA. So if a FLOAT32 snapshot is detected now the model will crash:This only applies when
ncdata_checkis set, in case the same null dycore functionality is used for non-CAM snapshot runs (thanks to @nusbaume for the suggestion)Describe any changes made to build system: N/A
Describe any changes made to the namelist: N/A
List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do: N/A
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
derecho/nvhpc/aux_sima:
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: