(HOLD until #477) Abstract aerosol interface; bulk aerosols (BAM); radiative_aerosol and physical props infra; optics core code; pfUnit tests#483
Draft
jimmielin wants to merge 10 commits intoESCOMP:developmentfrom
Conversation
…data; add src/aerosol to dir
…aerosol optics initial attempt. Misc build fixes Fix bugs in read_water_refindex Fix mark_as_initialized in host side src/aerosol/read_water_refindex.F90 Try metadata for radiative_aerosol_definitions Add mark_as_initialized for aerosol definitions
…s diagnostics (to merge into prev) (to merge into prev 2)
52509fa to
c4f5409
Compare
c4f5409 to
665485a
Compare
… squash of 3 Add aerosol pfUnit tests (coauthored with claude-opus-4.6) Remove not-used in CAM-SIMA gas parsing test (but still cover it in a gas+aerosol compound test with a note about deprecation) Remove not-used in CAM-SIMA gas parsing test (but still cover it in a gas+aerosol compound test with a note about deprecation)
be5c43e to
b9f01c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
Originator(s): @jimmielin coauthored with
claude-opus-4.6Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
aerosol_properties,aerosol_state,aerosol_optics);radiative_aerosol,radiative_aerosol_definitions), the CAM-SIMA equivalent of formerrad_constituents;aerosol_instances_mod);aerosol_physical_properties, formerlyphys_prop)bulk_aerosol_properties,bulk_aerosol_state) are fully implemented;aerosol_optics_corewhich dispatches optics object creation based on opticstype parameter verbatim from CAM;aerosol_mmr_ccppwhich retrieves aerosol mixing ratios from CCPP constituents (replacing CAM state and pbuf)table_interp_modfrom CAM for table interpolation.nswbandsandnlwbandsto theradiation_namelistfromatmos_physclaude-opus-4.6:Because there were many modules to test (while
aerosol_physical_properties.F90, formerlyphys_propuses PIO input), Claude made the following test decisions for unit testing:Describe any changes made to build system:
Describe any changes made to the namelist:
rad_aer_nl) with entries for mode_defs, bin_defs,rad_aer_climate(formerlyrad_climate), and rad_aer_diag_1 through rad_aer_diag_10.atmos_phys)List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
derecho/nvhpc/aux_sima:
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: