-
Notifications
You must be signed in to change notification settings - Fork 173
cam6_3_028: Science Updates and bug fixes for SE dycore. #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
f06ba04
9d9e8f6
bba0979
e639045
ecdb4ca
6f759fc
ee0edee
ef544d0
b5a6e0d
3db5d65
5c88161
97f989b
a8dcb53
de2e10f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,199 @@ | ||
| =============================================================== | ||
|
|
||
| Tag name: cam6_3_0XX | ||
| Originator(s): pel,jet | ||
| Date: July 14, 2021 | ||
| One-line Summary:Science Updates for CESM2.2 release and cam_development | ||
| Github PR URL: | ||
|
|
||
| Purpose of changes (include the issue number and title text for each relevant GitHub issue): | ||
| - These mods are necessary to fix science bugs, improve algorithms and numerical stability of SE dycore. | ||
| Namelist default changes to the gravity wave parameterization and updates to the Test Tracers will | ||
| also affect the other dycores. This PR will close issue #392. | ||
|
|
||
| Describe any changes made to build system: | ||
|
|
||
| Describe any changes made to the namelist: | ||
| - namelist variables have been removed: | ||
| se_raytau0 | ||
| se_raykrange | ||
| se_rayk0 | ||
| - namelist variables with new defaults | ||
| effgw_beres_dp defaults | ||
| se_hypervis_scaling | ||
| se_hypervis_subcycle | ||
| se_hypervis_subcycle_sponge | ||
| se_nu | ||
| se_nu_div | ||
| se_nu_p | ||
| se_nu_top | ||
| se_molecular_diff | ||
| se_nsplit | ||
| se_rsplit | ||
| cld_macmic_num_steps | ||
|
|
||
| List any changes to the defaults for the boundary datasets: | ||
|
|
||
| Describe any substantial timing or memory changes: | ||
|
|
||
| Code reviewed by: | ||
|
|
||
| List all files eliminated: | ||
|
|
||
| List all files added and what they do: | ||
|
||
|
|
||
| List all existing files that have been modified, and describe the changes: | ||
| . Remove SE Rayleigh Friction Parameterization | ||
| bld/build-namelist | ||
| bld/namelist_files/namelist_definition.xml | ||
| cime_config/testdefs/testmods_dirs/cam/outfrq9s_wcm_ne30/user_nl_cam | ||
| src/dynamics/se/dyn_comp.F90 | ||
|
|
||
| . Add reference temperature profile correction | ||
| . Remove SE Rayleigh Friction Parameterization | ||
| src/dynamics/se/dycore/prim_advance_mod.F90 | ||
|
|
||
| . Updated defaults for full physics | ||
| bld/namelist_files/namelist_defaults_cam.xml | ||
|
|
||
| . Thermodynamic consistency between pressure based physics and height based dynamics | ||
| src/dynamics/se/dp_coupling.F90 | ||
| src/dynamics/se/dycore/control_mod.F90 | ||
|
|
||
| . new del4 T damping variable and removed unused variables | ||
| src/dynamics/se/dycore/dimensions_mod.F90 | ||
|
Comment on lines
+63
to
+64
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Totally at your discretion (i.e. no need to change). I typically combine several files that have the exact same description together and then have the description follow. In this case, build-namelist, user_nl_cam, dyn_comp.F90 could all be grouped together with the "Remove SE Rayleigh Friction Parameterization" description. |
||
|
|
||
| . improve level dependent del4 (sponge layer) damping for hitop | ||
| src/dynamics/se/dycore/global_norms_mod.F90 | ||
|
|
||
| . add p correction to approximate Laplace on pressure surfaces | ||
| src/dynamics/se/dycore/viscosity_mod.F90 | ||
|
|
||
| . initialize angular momentum diagnostic variables. | ||
| src/physics/cam/check_energy.F90 | ||
|
|
||
| . fix dycore dependent calculation of hydrostatic elements | ||
| src/physics/cam/geopotential.F90 | ||
|
|
||
| . new angular moment diagnostics | ||
| src/physics/cam/physpkg.F90 | ||
| src/physics/simple/physpkg.F90 | ||
|
|
||
| . Changes to TT_CCOSB TT_COSB and TT_lCCOSB for idealized testing of | ||
| dynamical cores (change to Lauritzen and Thuburn,2012, QJRMS, formulation). | ||
| src/physics/cam/tracers.F90 | ||
|
|
||
| . correct mid-level pressure computation for SE in physconst.F90 | ||
| src/utils/physconst.F90 | ||
|
|
||
| If there were any failures reported from running test_driver.sh on any test | ||
| platform, and checkin with these failures has been OK'd by the gatekeeper, | ||
| then copy the lines from the td.*.status files for the failed tests to the | ||
| appropriate machine below. All failed tests must be justified. | ||
|
|
||
| cheyenne/intel/aux_cam: | ||
| All tests running. Differences Expected due to namelist updates | ||
|
|
||
| DIFF ERC_D_Ln9.f19_f19_mg17.QPX2000.cheyenne_intel.cam-outfrq3s | ||
| DIFF ERP_Lh12.f19_f19_mg17.FW4madSD.cheyenne_intel.cam-outfrq3h | ||
| DIFF ERP_Ln9.f19_f19_mg17.FWsc1850.cheyenne_intel.cam-outfrq9s | ||
| DIFF ERS_Ln9.f19_f19_mg17.FXSD.cheyenne_intel.cam-outfrq9s | ||
| DIFF SMS_D_Ln9.f19_f19_mg17.FWma2000climo.cheyenne_intel.cam-outfrq9s | ||
| DIFF SMS_D_Ln9.f19_f19_mg17.FXHIST.cheyenne_intel.cam-outfrq9s_amie | ||
| BASE: effgw_beres_dp = 0.1D0 | ||
| COMP: effgw_beres_dp = 0.7D0 | ||
|
|
||
| DIFF ERC_D_Ln9.mpasa120z32_mpasa120.FKESSLER.cheyenne_intel.cam-outfrq3s_usecase | ||
| test tracer differences | ||
|
|
||
| DIFF ERC_D_Ln9.ne16_ne16_mg17.FADIAB.cheyenne_intel.cam-terminator | ||
| DIFF ERC_D_Ln9.ne16_ne16_mg17.QPC5HIST.cheyenne_intel.cam-outfrq3s_usecase | ||
| DIFF ERP_Ln9.ne30_ne30_mg17.FCnudged.cheyenne_intel.cam-outfrq9s | ||
| DIFF SMS_Ld1.ne30pg3_ne30pg3_mg17.FC2010climo.cheyenne_intel.cam-outfrq1d | ||
| DIFF ERC_D_Ln9_P144x1.ne16pg3_ne16pg3_mg17.QPC6HIST.cheyenne_intel.cam-outfrq3s_ttrac_usecase | ||
| BASE: se_nu_top = 5.0e5 | ||
| COMP: se_nu_top = 1.25e5 | ||
|
|
||
| DIFF ERP_Ln9.ne30pg3_ne30pg3_mg17.FW2000climo.cheyenne_intel.cam-outfrq9s_wcm_ne30 | ||
| BASE: se_hypervis_subcycle = 1 | ||
| COMP: se_hypervis_subcycle = 2 | ||
| BASE: se_molecular_diff = 100.0 | ||
| COMP: se_molecular_diff = 0.0 | ||
| BASE: se_nu_top = 0.0 | ||
| COMP: se_nu_top = 1.25e5 | ||
| BASE: effgw_beres_dp = 0.325D0 | ||
| COMP: effgw_beres_dp = 0.5D0 | ||
|
|
||
| DIFF ERS_Ln9.ne0TESTONLYne5x4_ne0TESTONLYne5x4_mg37.FADIAB.cheyenne_intel.cam-outfrq3s_refined | ||
| BASE: se_hypervis_scaling = 3.0D0 | ||
| COMP: se_hypervis_scaling = 3.22D0 | ||
| BASE: se_hypervis_subcycle = 2 | ||
| COMP: se_hypervis_subcycle = 3 | ||
| BASE: se_hypervis_subcycle_sponge = 4 | ||
| COMP: se_hypervis_subcycle_sponge = 2 | ||
| BASE: se_nu_top = 2.0e5 | ||
| COMP: se_nu_top = 1.25e5 | ||
|
|
||
| DIFF SMS_D_Ln9.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.cheyenne_intel.cam-outfrq9s_refined_camchem | ||
| BASE: se_hypervis_scaling = 3.0D0 | ||
| COMP: se_hypervis_scaling = 3.22D0 | ||
| BASE: se_hypervis_subcycle = 2 | ||
| COMP: se_hypervis_subcycle = 3 | ||
| BASE: se_hypervis_subcycle_sponge = 4 | ||
| COMP: se_hypervis_subcycle_sponge = 2 | ||
| BASE: se_nu_top = 2.0e5 | ||
| COMP: se_nu_top = 1.25e5 | ||
| BASE: cld_macmic_num_steps = 3 | ||
| COMP: cld_macmic_num_steps = 1 | ||
|
|
||
| DIFF SMS_D_Ln9.ne16_ne16_mg17.QPX2000.cheyenne_intel.cam-outfrq9s | ||
| DIFF SMS_D_Ln9.ne16_ne16_mg17.FX2000.cheyenne_intel.cam-outfrq9s | ||
| BASE: se_hypervis_subcycle = 1 | ||
| COMP: se_hypervis_subcycle = 2 | ||
| BASE: se_molecular_diff = 0.0 | ||
| COMP: se_molecular_diff = 1.0 | ||
| BASE: effgw_beres_dp = 0.1D0 | ||
| COMP: effgw_beres_dp = 0.7D0 | ||
| BASE: se_hypervis_subcycle_sponge = 2 | ||
| COMP: se_hypervis_subcycle_sponge = 5 | ||
|
|
||
| izumi/nag/aux_cam: all BFB except: | ||
| FAIL DAE.f45_f45_mg37.FHS94.izumi_nag.cam-dae COMPARE_base_da | ||
| - pre-existing failure | ||
| DIFF ERC_D_Ln9.f10_f10_mg37.QPWmaC6.izumi_nag.cam-outfrq3s | ||
| DIFF ERC_D_Ln9.ne16_ne16_mg17.QPC4.izumi_nag.cam-outfrq3s_usecase | ||
| DIFF ERC_D_Ln9.ne16pg3_ne16pg3_mg17.QPC4.izumi_nag.cam-outfrq3s_usecase | ||
| DIFF ERC_D_Ln9.ne5_ne5_mg37.QPC5.izumi_nag.cam-outfrq3s_ttrac | ||
| DIFF ERI_D_Ln18.ne5_ne5_mg37.FADIAB.izumi_nag.cam-outfrq3s_bwic | ||
| DIFF ERI_D_Ln18.ne5pg3_ne5pg3_mg37.FADIAB.izumi_nag.cam-outfrq3s_bwic | ||
| DIFF ERP_Ln9.ne5pg3_ne5pg3_mg37.QPC6.izumi_nag.cam-outfrq9s_clubbmf | ||
| DIFF ERS_Ln27.ne5pg3_ne5pg3_mg37.FKESSLER.izumi_nag.cam-outfrq9s | ||
| DIFF ERS_Ln9.ne5_ne5_mg37.FADIAB.izumi_nag.cam-outfrq9s | ||
| DIFF PEM_D_Ln9.ne5_ne5_mg37.FADIAB.izumi_nag.cam-outfrq3s | ||
| DIFF PLB_D_Ln9.ne5_ne5_mg37.QPC5.izumi_nag.cam-ttrac_loadbal0 | ||
| DIFF PLB_D_Ln9.ne5_ne5_mg37.QPC5.izumi_nag.cam-ttrac_loadbal1 | ||
| DIFF PLB_D_Ln9.ne5_ne5_mg37.QPC5.izumi_nag.cam-ttrac_loadbal3 | ||
| DIFF SMS_D_Ln9.ne5_ne5_mg37.QPC4X.izumi_nag.cam-outfrq9s | ||
| DIFF SMS_D_Ln9_P1x1.ne5_ne5_mg37.FADIAB.izumi_nag.cam-outfrq3s | ||
| DIFF SMS_P48x1_D_Ln9.f19_f19_mg17.FW4madSD.izumi_nag.cam-outfrq9s | ||
| - Diff due to namelist updates - see comments for cheyenne testing | ||
|
|
||
| izumi/pgi/aux_cam: | ||
| DIFF ERC_D_Ln9.f10_f10_mg37.QPC4.izumi_pgi.cam-outfrq3s_diags | ||
| DIFF ERC_D_Ln9.ne5_ne5_mg37.QPC5.izumi_pgi.cam-outfrq3s_ba | ||
| DIFF ERC_D_Ln9.ne5pg2_ne5pg2_mg37.FADIAB.izumi_pgi.cam-outfrq3s | ||
| DIFF ERC_D_Ln9.ne5pg4_ne5pg4_mg37.FADIAB.izumi_pgi.cam-outfrq3s | ||
| DIFF ERP_Ln9.ne5_ne5_mg37.FHS94.izumi_pgi.cam-outfrq9s | ||
| DIFF ERP_Ln9.ne5_ne5_mg37.QPC5.izumi_pgi.cam-outfrq9s | ||
| DIFF PEM_D_Ln9.ne5pg3_ne5pg3_mg37.FADIAB.izumi_pgi.cam-outfrq3s | ||
| DIFF PLB_D_Ln9.ne5pg3_ne5pg3_mg37.QPC5.izumi_pgi.cam-ttrac_loadbal0 | ||
| DIFF PLB_D_Ln9.ne5pg3_ne5pg3_mg37.QPC5.izumi_pgi.cam-ttrac_loadbal1 | ||
| DIFF PLB_D_Ln9.ne5pg3_ne5pg3_mg37.QPC5.izumi_pgi.cam-ttrac_loadbal3 | ||
| DIFF SMS_D_Ln9.ne5pg3_ne5pg3_mg37.QPC5.izumi_pgi.cam-outfrq3s_ttrac | ||
| - Diff due to namelist updates - see comments for cheyenne testing | ||
| =============================================================== | ||
| =============================================================== | ||
|
|
||
| Tag name: cam6_3_025 | ||
| Originator(s): cacraig | ||
| Date: July 5, 2021 | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.