Skip to content

Adding a reproducible sum capability in CISM #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whlipscomb wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Adding a reproducible sum capability in CISM #78

Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
6a259ea
Fixed a temperature initialization bug
whlipscomb Nov 13, 2025
3669830
Merge branch 'main' into lipscomb/reprosum.new
whlipscomb Nov 25, 2025
6db094c
Work toward reproducible global sums
whlipscomb Nov 30, 2025
37df31d
Shortened some subroutine names in the cism_parallel module
whlipscomb Dec 5, 2025
0aae0b7
More work toward reproducible sums
whlipscomb Dec 19, 2025
deb5384
Change for reprosum testing
whlipscomb Jan 5, 2026
b9d44df
Replaced the reprosum code with Pat Worley's 2023 version
whlipscomb Jan 6, 2026
3be7b25
Reprosum fixes for glaciers
whlipscomb Jan 8, 2026
1a8f477
Subglacial hydrology changes to support reprosums
whlipscomb Jan 13, 2026
329fc87
Define two distinct temperature scales for basal hydrology
whlipscomb Jan 14, 2026
b1bf020
Changed the initialization logic for C_c and C_p
whlipscomb Jan 17, 2026
6569817
Reprosum abort logic for tridiagonal preconditioners
whlipscomb Jan 17, 2026
d4758c7
Removed infnan logic from the reprosum module
whlipscomb Jan 17, 2026
a8b597f
Fixed a logic bug in a parallel_sum subroutine
whlipscomb Jan 22, 2026
cf3a074
Enable tridiagonal preconditioners with all PCG solvers
whlipscomb Jan 23, 2026
d2c46ae
Reordered the PCG subroutines
whlipscomb Jan 23, 2026
e60ae9b
Reproducible sums for norm of residual vector
whlipscomb Jan 23, 2026
4a89b90
Reordered some subroutines in glissade_velo_higher
whlipscomb Jan 23, 2026
40718e1
Removed some verbose diagnostics
whlipscomb Jan 24, 2026
69a9199
Fixed a bug in the Picard acceleration
whlipscomb Feb 3, 2026
e5d6580
Added a modified Schoof basal sliding law
whlipscomb Feb 3, 2026
2edf195
Changes needed to compile with the GNU compiler
Katetc Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 4 additions & 21 deletions libglide/glide.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,7 @@ subroutine glide_initialise(model)
call glide_set_mask(model%numerics, &
model%geometry%thck, model%geometry%topg, &
model%general%ewn, model%general%nsn, &
model%climate%eus, model%geometry%thkmask, &
model%geometry%iarea, model%geometry%ivol)
model%climate%eus, model%geometry%thkmask)

! calculate lower and upper ice surface
call glide_calclsrf(model%geometry%thck, model%geometry%topg, model%climate%eus,model%geometry%lsrf)
Expand Down Expand Up @@ -503,16 +502,10 @@ subroutine glide_init_state_diagnostic(model, evolve_ice)
call glide_set_mask(model%numerics, &
model%geometry%thck, model%geometry%topg, &
model%general%ewn, model%general%nsn, &
model%climate%eus, model%geometry%thkmask, &
model%geometry%iarea, model%geometry%ivol)
model%climate%eus, model%geometry%thkmask)

endif ! calving_init

! Compute total areas of grounded and floating ice
call calc_iareaf_iareag(model%numerics%dew, model%numerics%dns, &
model%geometry%thkmask, &
model%geometry%iareaf, model%geometry%iareag)

! ------------------------------------------------------------------------
! ***Part 2: Calculate geometry related fields
! ------------------------------------------------------------------------
Expand Down Expand Up @@ -874,13 +867,10 @@ subroutine glide_tstep_p2(model)

call glide_prof_start(model,model%glide_prof%ice_mask2)

!TODO - Calculate area and vol separately from glide_set_mask?

call glide_set_mask(model%numerics, &
model%geometry%thck, model%geometry%topg, &
model%general%ewn, model%general%nsn, &
model%climate%eus, model%geometry%thkmask, &
model%geometry%iarea, model%geometry%ivol)
model%climate%eus, model%geometry%thkmask)

call glide_prof_stop(model,model%glide_prof%ice_mask2)

Expand Down Expand Up @@ -909,14 +899,7 @@ subroutine glide_tstep_p2(model)
call glide_set_mask(model%numerics, &
model%geometry%thck, model%geometry%topg, &
model%general%ewn, model%general%nsn, &
model%climate%eus, model%geometry%thkmask, &
model%geometry%iarea, model%geometry%ivol)
endif ! oldglide = F

if (.not. oldglide) then ! calculate area of floating and grounded ice
call calc_iareaf_iareag(model%numerics%dew, model%numerics%dns, &
model%geometry%thkmask, &
model%geometry%iareaf, model%geometry%iareag)
model%climate%eus, model%geometry%thkmask)
endif ! oldglide = F

! ------------------------------------------------------------------------
Expand Down
Loading