-
Notifications
You must be signed in to change notification settings - Fork 347
ctsm5.4.027: Important coupled model final answer changes: param file and n_melt_glcmec #3810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ekluzek
wants to merge
11
commits into
ESCOMP:master
Choose a base branch
from
ekluzek:important_final_answer_changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−6
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3e79994
Fix for #3799 so that lnd_tuning_mode can be used for the paramfile
ekluzek 220a9b1
Here's one way to get DATM_CO2_TSERIES settings just set for certain …
ekluzek 571e232
Merge branch 'master' into important_final_answer_changes
ekluzek a2a2309
Merge tag 'ctsm5.4.025' into important_final_answer_changes
ekluzek 2ccdbd9
Revert "Here's one way to get DATM_CO2_TSERIES settings just set for …
ekluzek 68ea7b7
Change n_melt_glcmec for clm6_0 fixing #3824
ekluzek 5423f3f
Put the 2015 ISSP finidat file inside namelist_defaults, so it can be…
ekluzek 59e94bd
Remove finidat file as it's set in the namelist defaults now
ekluzek 0ef99c2
Remove the user_nl_clm, because finidat files are now in namelist def…
ekluzek 6326827
Some adjustments to get the 2015 finidat working correctly
ekluzek 370da18
Correct use_excess_ice for 2015 finidat so will work with clm6_0 and …
ekluzek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
cime_config/testdefs/testmods_dirs/clm/ExcessIceStartup_output_sp_exice/user_nl_clm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| use_excess_ice = .true. | ||
| finidat = '$DIN_LOC_ROOT/lnd/clm2/initdata_map/clmi.I1850Clm50Sp.0003-01-01.0.9x1.25_gx1v7_exice_simyr1850_c221205.nc' | ||
| use_init_interp = .true. | ||
ekluzek marked this conversation as resolved.
Show resolved
Hide resolved
|
||
3 changes: 0 additions & 3 deletions
3
cime_config/testdefs/testmods_dirs/clm/ciso_dec2050Start/user_nl_clm
ekluzek marked this conversation as resolved.
Show resolved
Hide resolved
|
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that we might have applied this value only in coupled cases, but I see how it probably makes more sense to make the change for all clm6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, since the CISM folks want it changed, I think it should be changed for both coupled and uncoupled. That way any offline spinup with CISM will be consistent with coupled. And in general we want uncoupled cases to be the same as coupled unless there are really good reasons not to.