Skip to content

Add new register phases to RRTMGP schemes#366

Open
peverwhee wants to merge 169 commits intoESCOMP:mainfrom
peverwhee:rrtmgp-reorg
Open

Add new register phases to RRTMGP schemes#366
peverwhee wants to merge 169 commits intoESCOMP:mainfrom
peverwhee:rrtmgp-reorg

Conversation

@peverwhee
Copy link
Collaborator

Tag name (The PR title should also include the tag name): TBD
Originator(s): peverwhee, fvitt

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
To allow chemistry packages (like CARMA) to access wavelength band info (needed by @fvitt), this PR reorganizes RRTMGP schemes slightly.

  1. Adds new register phase to the rrtmgp_inputs_setup scheme
  2. renames a couple of init phases to register phases

List all namelist files that were added or changed: n/a

List all files eliminated and why: n/a

List all files added and what they do: n/a

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M    schemes/rrtmgp/rrtmgp_inputs_setup.F90
M    schemes/rrtmgp/rrtmgp_inputs_setup.meta
- separates rrtmgp_inputs_setup_init into _register and _init (register phase sets wavelength band numbers)

M    schemes/rrtmgp/rrtmgp_lw_gas_optics.F90
M    schemes/rrtmgp/rrtmgp_lw_gas_optics.meta
M    schemes/rrtmgp/rrtmgp_pre.F90
M    schemes/rrtmgp/rrtmgp_pre.meta
M    schemes/rrtmgp/rrtmgp_sw_gas_optics.F90
M    schemes/rrtmgp/rrtmgp_sw_gas_optics.meta
M    schemes/rrtmgp/utils/radiation_utils.F90
- turn init phases into register phases to account for rrtmgp_inputs_setup changes

List all automated tests that failed, as well as an explanation for why they weren't fixed: n/a

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc? no

If yes to the above question, describe how this code was validated with the new/modified features:

Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peverwhee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants