Skip to content

Merge development to main (for tracer_data)#368

Merged
jimmielin merged 1 commit intomainfrom
development
Mar 9, 2026
Merged

Merge development to main (for tracer_data)#368
jimmielin merged 1 commit intomainfrom
development

Conversation

@jimmielin
Copy link
Member

Includes #331 by @jimmielin

This is a development to main PR to bring in originally PRs that were opened against development and now merged.

…x for bulk aerosols (BAM) (#331)

Originator(s): @jimmielin

Most of the code based off from @fvitt; changes had to be made to remove
use of pbuf and use the constituents infrastructure in CAM-SIMA/CCPP
framework to register store prescribed aerosols data (code borrowed from
@peverwhee and @nusbaume)

Companion SIMA PR ESCOMP/CAM-SIMA#441

There will not be a CAM PR to bring these changes back because
`tracer_data` has breaking interface changes (and no longer using pbuf)
that make it infeasible to bring back these schemes into CAM.

Description (include issue title and the keyword ['closes', 'fixes',
'resolves'] and issue number):
- CCPPize CAM `prescribed_ozone` -- closes #323
- CCPPize CAM `prescribed_aero` into `prescribed_aerosols` scheme --
closes #328
- Partially CCPPize CAM `aerodep_flx` into
`prescribed_aerosol_deposition_flux` scheme: only BAM functionality is
fully implemented; MAM functionality depends on conversion of the
aerosol model -- closes #328; future work documented in #329

List all namelist files that were added or changed:
```
A       schemes/chemistry/prescribed_ozone_namelist.xml
A       schemes/chemistry/prescribed_aerosols_namelist.xml
A       schemes/chemistry/prescribed_aerosol_deposition_flux_namelist.xml
```

List all files eliminated and why: N/A

List all files added and what they do:
```
A       schemes/chemistry/prescribed_ozone.F90
A       schemes/chemistry/prescribed_ozone.meta
  - complete CCPPization of prescribed_ozone (#323)

A       schemes/chemistry/prescribed_aerosols.F90
A       schemes/chemistry/prescribed_aerosols.meta
  - complete CCPPization of prescribed_aero (#328)

A       schemes/chemistry/prescribed_aerosol_deposition_flux.F90
A       schemes/chemistry/prescribed_aerosol_deposition_flux.meta
  - CCPPize aerodep_flx for bulk aerosols (BAM) only. (#328) future work #329

A       test/test_suites/suite_tracer_data_test.xml
  - suite for testing tracer_data chemistry and aerosols input test via prescribed ozone, aerosols, and aerosol deposition flux -- BAM configuration
```

List all existing files that have been modified, and describe the
changes:
(Helpful git command: `git diff --name-status
development...<your_branch_name>`)
N/A

List all automated tests that failed, as well as an explanation for why
they weren't fixed: N/A

Is this an answer-changing PR? If so, is it a new physics package,
algorithm change, tuning change, etc?
new chemistry and aerosol schemes

If yes to the above question, describe how this code was validated with
the new/modified features:
new regression test verified b4b with cam using same namelist options
and input files as described in testmod - see CAM-SIMA PR

---------

Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
@jimmielin jimmielin self-assigned this Mar 9, 2026
@jimmielin jimmielin requested a review from nusbaume March 9, 2026 15:11
@jimmielin jimmielin requested a review from peverwhee March 9, 2026 15:34
Copy link
Collaborator

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jimmielin !

@jimmielin jimmielin merged commit 3f5435e into main Mar 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants