Draft
Conversation
ekluzek
added
enhancement
Collaborator
|
Hi Erik (@ekluzek), you pull-requested to main branch(This is still serial version main trunk). I guess you meant to merge into cesm-coupling? |
Collaborator
Author
|
Good point. I'll fix that. |
…nto cesm_build_changes
…nto cesm_build_changes
…gth for the X edit descriptor, which is required to compile with nag, it is required in the fortran standard, so this addresses part of ESCOMP#275
…ays available on all compilers, addresses ESCOMP#275
…s available on all compilers, addresses ESCOMP#275
nmizukami
reviewed
Apr 14, 2022
| USE globalData, ONLY: masterproc | ||
| USE public_var, ONLY: root | ||
| USE public_var, ONLY: iulog | ||
| USE shr_sys_mod,ONLY: shr_sys_flush |
Collaborator
There was a problem hiding this comment.
Hi Erik, wondering how this works for stand-alone. does stand-alone access to shr_sys_mod?
Collaborator
Author
There was a problem hiding this comment.
We can make it available. I think the standalone build will have to change a little bit, but not too much. I plan to make a crack at that a bit later.
…sm_build_changes Conflicts: route/build/src/mpi_utils.f90
…ready done just above, you could nullify the previous pointer after deallocating it, and then you could check if list is associated, since it would be nullified, as is now it fails on doing the associated function on a dangling pointer
… two dummy arguments in a subroutine, so added a check that the index weren't the same, and also only do the swap if the valus are actually different
… ER test with nag, add a 5x5 threaded test since the 1x25 one fails on izumi
Collaborator
Author
|
Most of the things needed here came in. But, it looks like there might be a few useful things to preserve from here. But, there are a good number of conflicts that will take time to resolve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring in some important changes for the cesm build. Also get the test list on izumi overall working.
Issues addressed:
Fixes #281 Done
Fixes #277 Done
Fixes #259 Done
Fixes #266 Done
Fixes #262
Fixes #275 Done
Fixes #276 Fix for standalone build
Fixes #270 ?
Fixes #238 ?